Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2503433003: Move ProcessHeap::isLowEndDevice to MemoryCoordinator (Closed)

Created:
4 years, 1 month ago by whywhat
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
Mads Ager (chromium), blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, kouhei+heap_chromium.org, loading-reviews+fetch_chromium.org, oilpan-reviews, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ProcessHeap::isLowEndDevice to MemoryCoordinator Per discussion at https://codereview.chromium.org/2475293003 BUG=None Committed: https://crrev.com/6d436afa31364d59752915155a40e8afba13cd03 Cr-Commit-Position: refs/heads/master@{#432427}

Patch Set 1 #

Patch Set 2 : Fixed compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/MemoryCoordinator.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/MemoryCoordinator.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (10 generated)
whywhat
PTaL
4 years, 1 month ago (2016-11-15 08:40:59 UTC) #4
haraken
LGTM, thanks!
4 years, 1 month ago (2016-11-15 08:49:21 UTC) #5
whywhat
Fixed compile
4 years, 1 month ago (2016-11-15 20:19:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503433003/20001
4 years, 1 month ago (2016-11-15 20:21:15 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/260936)
4 years, 1 month ago (2016-11-15 20:41:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503433003/20001
4 years, 1 month ago (2016-11-16 08:11:49 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 08:17:21 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6d436afa31364d59752915155a40e8afba13cd03 Cr-Commit-Position: refs/heads/master@{#432427}
4 years, 1 month ago (2016-11-16 08:23:20 UTC) #18
suzyh_UTC10 (ex-contributor)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2510623002/ by suzyh@chromium.org. ...
4 years, 1 month ago (2016-11-16 09:13:48 UTC) #19
whywhat
4 years, 1 month ago (2016-11-18 19:13:44 UTC) #20
Message was sent while issue was closed.
On 2016/11/16 at 09:13:48, suzyh wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2510623002/ by suzyh@chromium.org.
> 
> The reason for reverting is: Suspected to be responsible for breaking blink
heap unittests..

Have you confirmed the suspicion?

Powered by Google App Engine
This is Rietveld 408576698