Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2542633002: [turbofan] Workaround for unknown array literal length. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Workaround for unknown array literal length. This fixes the existing workaround in {BytecodeGraphBuilder} where the number of elements in an array literal is unknown just from the bytecode alone and needs to be deduced from the constant elements. Note that this is just a quick fix to prevent calling the fast-clone stub for boilerplates that are too big to fit on a regular page. In the long run we need something more solid here. R=mvstanton@chromium.org TEST=mjsunit/regress/regress-crbug-669850 BUG=chromium:669850 Committed: https://crrev.com/f8fec66f0be7489de4673a6271f893b05d11b49c Cr-Commit-Position: refs/heads/master@{#41420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 2 chunks +9 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-669850.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Starzinger
4 years ago (2016-11-30 15:53:36 UTC) #3
mvstanton
lgtm
4 years ago (2016-12-01 11:49:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542633002/1
4 years ago (2016-12-01 11:59:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 12:00:53 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 12:01:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8fec66f0be7489de4673a6271f893b05d11b49c
Cr-Commit-Position: refs/heads/master@{#41420}

Powered by Google App Engine
This is Rietveld 408576698