Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: components/password_manager/core/browser/password_autofill_manager_unittest.cc

Issue 2542593003: HTTP Bad: Add a seperator between http warning message and other entries (Closed)
Patch Set: fix win trybots Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_autofill_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_autofill_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_autofill_manager_unittest.cc b/components/password_manager/core/browser/password_autofill_manager_unittest.cc
index c63d781e6749363c5a3bcd753915d0607ec99462..617c5ca00646aac197cdb6b66b1658c89e6c4669 100644
--- a/components/password_manager/core/browser/password_autofill_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_autofill_manager_unittest.cc
@@ -619,13 +619,17 @@ TEST_F(PasswordAutofillManagerTest, NonSecurePasswordFieldHttpWarningMessage) {
kMarkHttpWithPasswordsOrCcWithChipAndFormWarning);
// Http warning message shows for non-secure context and switch flag on, so
- // there are 3 suggestions in total, and the message comes first among
- // suggestions.
+ // there are 3 suggestions (+ 1 separator on desktop) in total, and the
+ // message comes first among suggestions.
+ auto elements = testing::ElementsAre(warning_message,
+#if !defined(OS_ANDROID)
+ base::string16(),
+#endif
+ title, test_username_);
+
EXPECT_CALL(*autofill_client,
ShowAutofillPopup(element_bounds, _,
- SuggestionVectorValuesAre(testing::ElementsAre(
- warning_message, title, test_username_)),
- _));
+ SuggestionVectorValuesAre(elements), _));
password_autofill_manager_->OnShowPasswordSuggestions(
dummy_key, base::i18n::RIGHT_TO_LEFT, test_username_,
autofill::IS_PASSWORD_FIELD, element_bounds);
« no previous file with comments | « components/password_manager/core/browser/password_autofill_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698