components/password_manager/core/browser/password_autofill_manager.cc - Issue 2542593003: HTTP Bad: Add a seperator between http warning message and other entries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager.cc

Issue 2542593003: HTTP Bad: Add a seperator between http warning message and other entries (Closed)

Patch Set: fix win trybots Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/password_manager/core/browser/password_autofill_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager.cc

diff --git a/components/password_manager/core/browser/password_autofill_manager.cc b/components/password_manager/core/browser/password_autofill_manager.cc

index b0a14d5f5432ffa341069bf3812a91e74653c6eb..1c0b1bf1540507e7b817210795cf49c0b5ccc2c0 100644

--- a/components/password_manager/core/browser/password_autofill_manager.cc

+++ b/components/password_manager/core/browser/password_autofill_manager.cc

@@ -232,6 +232,10 @@ void PasswordAutofillManager::OnShowPasswordSuggestions(

l10n_util::GetStringUTF8(IDS_AUTOFILL_PASSWORD_HTTP_WARNING_MESSAGE),

l10n_util::GetStringUTF8(IDS_AUTOFILL_HTTP_WARNING_LEARN_MORE),

icon_str, autofill::POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE);

+#if !defined(OS_ANDROID)

+ suggestions.insert(suggestions.begin(), autofill::Suggestion());

+ suggestions.front().frontend_id = autofill::POPUP_ITEM_ID_SEPARATOR;

+#endif

suggestions.insert(suggestions.begin(),

password_field_http_warning_suggestion);

}