Clang scripts updates.

Clang scripts updates.

Two updates are proposed for clang scripts:
An optional parameter is added to run_tool.py called (tool-param) that is directly passed to the tool that is run.
An optional parameter is added to generate_win_compdb.py to specify the build directory. Its default value is out/Debug so that it won't change the previous behavior.

BUG=670072
Committed: https://crrev.com/a237428c35769715e397f8ff0df9d1e223b10345
Cr-Commit-Position: refs/heads/master@{#435532}

[Ramin Halavati, 2016-11-30 04:21:45]

Description was changed from

==========
Clang script updates.

Two updates are proposed for clang scripts:
An optional parameter is added to run_tool.py called (tool-param) that is
directly passed to the tool that is run.
An optinal parameter is added to generate_win_compdb.py to specify the build
directory. Its default value is out/Debug so that it won't change the previous
behaviour.

BUG=
==========

to

==========
Clang scripts updates.

Two updates are proposed for clang scripts:
An optional parameter is added to run_tool.py called (tool-param) that is
directly passed to the tool that is run.
An optional parameter is added to generate_win_compdb.py to specify the build
directory. Its default value is out/Debug so that it won't change the previous
behavior.

BUG=
==========

[Ramin Halavati, 2016-11-30 04:22:11]

rhalavati@chromium.org changed reviewers:
+ dcheng@chromium.org

[Ramin Halavati, 2016-11-30 04:22:12]

Hi Daniel,

I've made two modifications to clang scripts. Please review them.

[dcheng, 2016-11-30 05:19:20]

I think this looks reasonable overall; my main concern with --tool-param is that
it's a bit hard to use, especially if you want to pass in multiple arguments. Is
it possible to make it somehow accept multiple arguments? Maybe something along
the lines of gdb's --arg?

https://codereview.chromium.org/2542563002/diff/1/tools/clang/scripts/run_too...
File tools/clang/scripts/run_tool.py (right):

https://codereview.chromium.org/2542563002/diff/1/tools/clang/scripts/run_too...
tools/clang/scripts/run_tool.py:308: '--tool-param', type=str,
Nit: the default is string already.

[Ramin Halavati, 2016-11-30 22:04:16]

Changed run_tool.py so that an arbitrary number of arguments can be passed to
the tool. Please review.

[Ramin Halavati, 2016-11-30 22:11:37]

Description was changed from

==========
Clang scripts updates.

Two updates are proposed for clang scripts:
An optional parameter is added to run_tool.py called (tool-param) that is
directly passed to the tool that is run.
An optional parameter is added to generate_win_compdb.py to specify the build
directory. Its default value is out/Debug so that it won't change the previous
behavior.

BUG=
==========

to

==========
Clang scripts updates.

Two updates are proposed for clang scripts:
An optional parameter is added to run_tool.py called (tool-param) that is
directly passed to the tool that is run.
An optional parameter is added to generate_win_compdb.py to specify the build
directory. Its default value is out/Debug so that it won't change the previous
behavior.

BUG=670072
==========

[dcheng, 2016-12-01 01:09:26]

lgtm with a nit

https://codereview.chromium.org/2542563002/diff/20001/tools/clang/scripts/run...
File tools/clang/scripts/run_tool.py (right):

https://codereview.chromium.org/2542563002/diff/20001/tools/clang/scripts/run...
tools/clang/scripts/run_tool.py:142: command = subprocess.Popen(tuple(args),
Nit: remove tuple() here, args just needs to be an iterable, and I usually
default to tuple instead of list when it doesn't need to be mutable.

[Ramin Halavati, 2016-12-01 02:29:10]

The CQ bit was checked by rhalavati@chromium.org

[Ramin Halavati, 2016-12-01 02:29:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2542563002/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2016-12-01 02:29:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ramin Halavati, 2016-12-01 02:32:48]

Comments addressed. Thanks for review and approval.

https://codereview.chromium.org/2542563002/diff/20001/tools/clang/scripts/run...
File tools/clang/scripts/run_tool.py (right):

https://codereview.chromium.org/2542563002/diff/20001/tools/clang/scripts/run...
tools/clang/scripts/run_tool.py:142: command = subprocess.Popen(tuple(args),
On 2016/12/01 01:09:26, dcheng wrote:
> Nit: remove tuple() here, args just needs to be an iterable, and I usually
> default to tuple instead of list when it doesn't need to be mutable.

Done.

[commit-bot: I haz the power, 2016-12-01 02:37:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480559350243560,
"parent_rev": "dd4bdfba69eef88d6620dc2ea0ce78953b86eed2", "commit_rev":
"2601073071f34091c1829092f351e3ef7931009b"}

[commit-bot: I haz the power, 2016-12-01 02:37:33]

Description was changed from

==========
Clang scripts updates.

Two updates are proposed for clang scripts:
An optional parameter is added to run_tool.py called (tool-param) that is
directly passed to the tool that is run.
An optional parameter is added to generate_win_compdb.py to specify the build
directory. Its default value is out/Debug so that it won't change the previous
behavior.

BUG=670072
==========

to

==========
Clang scripts updates.

Two updates are proposed for clang scripts:
An optional parameter is added to run_tool.py called (tool-param) that is
directly passed to the tool that is run.
An optional parameter is added to generate_win_compdb.py to specify the build
directory. Its default value is out/Debug so that it won't change the previous
behavior.

BUG=670072
==========

[commit-bot: I haz the power, 2016-12-01 02:37:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-01 02:40:28]

Description was changed from

==========
Clang scripts updates.

Two updates are proposed for clang scripts:
An optional parameter is added to run_tool.py called (tool-param) that is
directly passed to the tool that is run.
An optional parameter is added to generate_win_compdb.py to specify the build
directory. Its default value is out/Debug so that it won't change the previous
behavior.

BUG=670072
==========

to

==========
Clang scripts updates.

Two updates are proposed for clang scripts:
An optional parameter is added to run_tool.py called (tool-param) that is
directly passed to the tool that is run.
An optional parameter is added to generate_win_compdb.py to specify the build
directory. Its default value is out/Debug so that it won't change the previous
behavior.

BUG=670072

Committed: https://crrev.com/a237428c35769715e397f8ff0df9d1e223b10345
Cr-Commit-Position: refs/heads/master@{#435532}
==========

[commit-bot: I haz the power, 2016-12-01 02:40:29]

Patchset 3 (id:??) landed as
https://crrev.com/a237428c35769715e397f8ff0df9d1e223b10345
Cr-Commit-Position: refs/heads/master@{#435532}