Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 2542563002: Clang scripts updates. (Closed)

Created:
3 years, 11 months ago by Ramin Halavati
Modified:
3 years, 10 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clang scripts updates. Two updates are proposed for clang scripts: An optional parameter is added to run_tool.py called (tool-param) that is directly passed to the tool that is run. An optional parameter is added to generate_win_compdb.py to specify the build directory. Its default value is out/Debug so that it won't change the previous behavior. BUG=670072 Committed: https://crrev.com/a237428c35769715e397f8ff0df9d1e223b10345 Cr-Commit-Position: refs/heads/master@{#435532}

Patch Set 1 #

Total comments: 1

Patch Set 2 : tool-args generalized #

Total comments: 2

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -11 lines) Patch
M tools/clang/scripts/generate_win_compdb.py View 3 chunks +11 lines, -2 lines 0 comments Download
M tools/clang/scripts/run_tool.py View 1 2 8 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Ramin Halavati
Hi Daniel, I've made two modifications to clang scripts. Please review them.
3 years, 11 months ago (2016-11-30 04:22:12 UTC) #3
dcheng
I think this looks reasonable overall; my main concern with --tool-param is that it's a ...
3 years, 11 months ago (2016-11-30 05:19:20 UTC) #4
Ramin Halavati
Changed run_tool.py so that an arbitrary number of arguments can be passed to the tool. ...
3 years, 10 months ago (2016-11-30 22:04:16 UTC) #5
dcheng
lgtm with a nit https://codereview.chromium.org/2542563002/diff/20001/tools/clang/scripts/run_tool.py File tools/clang/scripts/run_tool.py (right): https://codereview.chromium.org/2542563002/diff/20001/tools/clang/scripts/run_tool.py#newcode142 tools/clang/scripts/run_tool.py:142: command = subprocess.Popen(tuple(args), Nit: remove ...
3 years, 10 months ago (2016-12-01 01:09:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542563002/40001
3 years, 10 months ago (2016-12-01 02:29:32 UTC) #10
Ramin Halavati
Comments addressed. Thanks for review and approval. https://codereview.chromium.org/2542563002/diff/20001/tools/clang/scripts/run_tool.py File tools/clang/scripts/run_tool.py (right): https://codereview.chromium.org/2542563002/diff/20001/tools/clang/scripts/run_tool.py#newcode142 tools/clang/scripts/run_tool.py:142: command = ...
3 years, 10 months ago (2016-12-01 02:32:48 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 10 months ago (2016-12-01 02:37:34 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2016-12-01 02:40:29 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a237428c35769715e397f8ff0df9d1e223b10345
Cr-Commit-Position: refs/heads/master@{#435532}

Powered by Google App Engine
This is Rietveld 408576698