Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2542553002: [Devtools] Fixed flakey network-columns-sorted.html test (Closed)

Created:
4 years ago by allada
Modified:
4 years ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed flakey network-columns-sorted.html test Fixes recently added flakey test. R=dgozman,lushnikov BUG=669753 Committed: https://crrev.com/82ef6cfd810f4acb06a7aafc598fefc806773b12 Cr-Commit-Position: refs/heads/master@{#435391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted.html View 3 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
allada
PTL
4 years ago (2016-11-30 03:02:03 UTC) #2
lushnikov
lgtm
4 years ago (2016-11-30 03:55:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542553002/1
4 years ago (2016-11-30 04:44:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on ...
4 years ago (2016-11-30 05:04:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542553002/1
4 years ago (2016-11-30 19:14:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 20:03:34 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/82ef6cfd810f4acb06a7aafc598fefc806773b12 Cr-Commit-Position: refs/heads/master@{#435391}
4 years ago (2016-11-30 20:06:25 UTC) #15
alph
4 years ago (2016-12-06 18:56:45 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2554093003/ by alph@chromium.org.

The reason for reverting is: Broke timeline tree view.
BUG=671487.

Powered by Google App Engine
This is Rietveld 408576698