Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted.html

Issue 2542553002: [Devtools] Fixed flakey network-columns-sorted.html test (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted.html
index d36ddb69f9786c46d502f45283e7db6f672955b8..b1bbcc0e062d8b399e872e087b319087a28bb4d3 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted.html
@@ -8,13 +8,15 @@ function test()
InspectorTest.recordNetwork();
var totalResourceCount = 4;
- InspectorTest.makeFetch("resources/style.css", {}, ensureAllResources);
- InspectorTest.makeFetch("resources/abe.png", {}, () => {
- // Ensures result is cached.
- InspectorTest.makeFetch("resources/abe.png", {}, ensureAllResources);
- ensureAllResources();
- });
- InspectorTest.makeFetch("missing/foo.bar", {}, ensureAllResources);
+ function fetchRequests() {
+ InspectorTest.makeFetch("resources/style.css", {}, ensureAllResources);
+ InspectorTest.makeFetch("resources/abe.png", {}, () => {
+ // Ensures result is cached.
+ InspectorTest.makeFetch("resources/abe.png", {}, ensureAllResources);
+ ensureAllResources();
+ });
+ InspectorTest.makeFetch("missing/foo.bar", {}, ensureAllResources);
+ }
var resourceCount = 0;
function ensureAllResources()
@@ -36,12 +38,8 @@ function test()
dataGrid.markColumnAsSortedBy('name', UI.DataGrid.Order.Ascending);
columnsView.sortByCurrentColumn();
- dataGrid.markColumnAsSortedBy('status', UI.DataGrid.Order.Ascending);
- columnsView.sortByCurrentColumn();
dataGrid.markColumnAsSortedBy('name', UI.DataGrid.Order.Descending);
columnsView.sortByCurrentColumn();
- dataGrid.markColumnAsSortedBy('type', UI.DataGrid.Order.Ascending);
- columnsView.sortByCurrentColumn();
}
function dataGridSorted(logView)
@@ -52,6 +50,7 @@ function test()
InspectorTest.addResult(" " + node.request().name());
InspectorTest.addResult("");
}
+ fetchRequests();
}
</script>
</head>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-sorted-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698