third_party/WebKit/Source/core/inspector/browser_protocol.json - Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows. (Closed)

Patch Set: Redefine event parameter (optional instead of nullable) for Closure Compiler Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/protocol/security_handler.cc ('K') | « third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/browser_protocol.json

diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json

index f2edae65c7f69087d5510ebd9ab2bb813673392f..47da2f23b68384bc053e443dd9aa67cedd83330c 100644

--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json

+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json

@@ -906,6 +906,7 @@

"parameters": [

{ "name": "securityState", "$ref": "SecurityState", "description": "Security state." },

{ "name": "explanations", "type": "array", "items": { "$ref": "SecurityStateExplanation" }, "description": "List of explanations for the security state. If the overall security state is `insecure` or `warning`, at least one corresponding explanation should be included.", "optional": true },

+ { "name": "summary", "type": "string", "description": "User-visible description of the state.", "optional": true },

{ "name": "insecureContentStatus", "$ref": "InsecureContentStatus", "description": "Information about insecure content on the page.", "optional": true },

{ "name": "schemeIsCryptographic", "type": "boolean", "description": "True if the page was loaded over cryptographic transport such as HTTPS.", "optional": true }

]