content/browser/devtools/protocol/security_handler.cc - Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/security_handler.cc

Issue 2542533004: Override DevTools security summary when a Safe Browsing warning shows. (Closed)

Patch Set: Redefine event parameter (optional instead of nullable) for Closure Compiler Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol/security_handler.cc

diff --git a/content/browser/devtools/protocol/security_handler.cc b/content/browser/devtools/protocol/security_handler.cc

index d3efa82257fbed81b3698de5f86068e161e2816d..89ebe7fea0f5ef778b5acd077d8157141b0a9312 100644

--- a/content/browser/devtools/protocol/security_handler.cc

+++ b/content/browser/devtools/protocol/security_handler.cc

@@ -132,6 +132,7 @@ void SecurityHandler::SecurityStyleChanged(

->set_security_state(security_state)

->set_scheme_is_cryptographic(

security_style_explanations.scheme_is_cryptographic)

+ ->set_summary(security_style_explanations.summary)

estark 2016/12/07 01:00:09 Maybe you only want to set this if |summary| is no

->set_insecure_content_status(insecure_content_status)

->set_explanations(explanations));

}