Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2542533003: Revert of VEA unittest: add a test case for cache line-alignment (Closed)

Created:
4 years ago by battre
Modified:
4 years ago
Reviewers:
Owen Lin, wuchengli, hywu, hywu1
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org, henryhsu, Pawel Osciak
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of VEA unittest: add a test case for cache line-alignment (patchset #8 id:140001 of https://codereview.chromium.org/2525563005/ ) Reason for revert: Breaks the compilation on mac. Original issue's description: > VEA unittest: add a test case for cache line-alignment > > Linux refuses to accept buffers that have sizes ualigned to > CPU cache line, which can be 128 bytes on certain devices. > This test inputs a frame that has unaligned size of U and V > planes to catch such errors. > > BUG=664039 > TEST=Run VEA unittest on Kevin. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a > Cr-Commit-Position: refs/heads/master@{#435179} TBR=wuchengli@chromium.org,hywu@chromium.org,owenlin@chromium.org,hywu@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664039 Committed: https://crrev.com/ab2576fd118981251ac96db03d933fa4468549bd Cr-Commit-Position: refs/heads/master@{#435199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -272 lines) Patch
M media/gpu/video_encode_accelerator_unittest.cc View 17 chunks +148 lines, -272 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
battre
Created Revert of VEA unittest: add a test case for cache line-alignment
4 years ago (2016-11-30 09:35:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542533003/1
4 years ago (2016-11-30 09:35:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 09:36:33 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-30 09:39:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab2576fd118981251ac96db03d933fa4468549bd
Cr-Commit-Position: refs/heads/master@{#435199}

Powered by Google App Engine
This is Rietveld 408576698