Issue 2542503002: [Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2542503002: [Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment (Closed)

Created:
4 years ago by jianli

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

[Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment * Adding a test and fixing the issue BUG=669126 Review-Url: https://codereview.chromium.org/2535023002 Cr-Commit-Position: refs/heads/master@{#434811} (cherry picked from commit 1acc2c4283c64636eb2a120f3e1e51267f74a427) Committed: https://chromium.googlesource.com/chromium/src/+/98729734658f98e96eb03d83452e088e9e2d8bd8

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -1 line)			Patch
M	chrome/browser/android/offline_pages/offline_page_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/offline_pages/offline_page_utils_unittest.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/previews/previews_infobar_tab_helper_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

jianli

4 years ago (2016-11-30 00:27:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
98729734658f98e96eb03d83452e088e9e2d8bd8.