[Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment

[Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment

* Adding a test and fixing the issue

BUG=669126
Committed: https://crrev.com/1acc2c4283c64636eb2a120f3e1e51267f74a427
Cr-Commit-Position: refs/heads/master@{#434811}

[fgorski, 2016-11-28 19:02:25]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 19:03:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 20:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 20:22:17]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[fgorski, 2016-11-28 22:05:32]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 22:07:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-11-28 22:08:43]

fgorski@chromium.org changed reviewers:
+ jianli@chromium.org, ryansturm@chromium.org

[fgorski, 2016-11-28 22:08:43]

PTAL

[jianli, 2016-11-28 22:18:56]

lgtm

Thanks for finding and fixing this.

https://codereview.chromium.org/2535023002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
(right):

https://codereview.chromium.org/2535023002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/offline_page_utils_unittest.cc:268:
EXPECT_TRUE(OfflinePageUtils::EqualsIgnoringFragment(
Please add more coverage like the followings:
  EXPECT_TRUE(OfflinePageUtils::EqualsIgnoringFragment(
      GURL("http://example.com/#test"), GURL("http://example.com/")));
  EXPECT_TRUE(OfflinePageUtils::EqualsIgnoringFragment(
      GURL("http://example.com/#test"), GURL("http://example.com/#test2")));

[RyanSturm, 2016-11-28 22:31:12]

chrome/browser/previews lgtm

[fgorski, 2016-11-28 23:14:50]

Addressed

https://codereview.chromium.org/2535023002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
(right):

https://codereview.chromium.org/2535023002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/offline_page_utils_unittest.cc:268:
EXPECT_TRUE(OfflinePageUtils::EqualsIgnoringFragment(
On 2016/11/28 22:18:56, jianli wrote:
> Please add more coverage like the followings:
>   EXPECT_TRUE(OfflinePageUtils::EqualsIgnoringFragment(
>       GURL("http://example.com/#test"), GURL("http://example.com/")));
>   EXPECT_TRUE(OfflinePageUtils::EqualsIgnoringFragment(
>       GURL("http://example.com/#test"), GURL("http://example.com/#test2")));

Done.

[fgorski, 2016-11-28 23:14:57]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-11-28 23:14:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org, jianli@chromium.org
Link to the patchset: https://codereview.chromium.org/2535023002/#ps40001
(title: "Addressing feedback")

[commit-bot: I haz the power, 2016-11-28 23:16:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2016-11-29 00:40:39]

fly-by: please change CL description:
s/EqualsIgnoringFormat/EqualsIgnoringFragment/

[fgorski, 2016-11-29 00:49:48]

Description was changed from

==========
[Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFormat

* Adding a test and fixing the issue

BUG=669126
==========

to

==========
[Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment

* Adding a test and fixing the issue

BUG=669126
==========

[commit-bot: I haz the power, 2016-11-29 01:15:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480374897739790,
"parent_rev": "bb3c492567bd4c2d425766ac53bc294158bb55ca", "commit_rev":
"5c9a5602b6939220cb14cc28754177efb08ff389"}

[commit-bot: I haz the power, 2016-11-29 01:16:54]

Description was changed from

==========
[Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment

* Adding a test and fixing the issue

BUG=669126
==========

to

==========
[Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment

* Adding a test and fixing the issue

BUG=669126
==========

[commit-bot: I haz the power, 2016-11-29 01:16:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-29 01:25:13]

Description was changed from

==========
[Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment

* Adding a test and fixing the issue

BUG=669126
==========

to

==========
[Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment

* Adding a test and fixing the issue

BUG=669126

Committed: https://crrev.com/1acc2c4283c64636eb2a120f3e1e51267f74a427
Cr-Commit-Position: refs/heads/master@{#434811}
==========

[commit-bot: I haz the power, 2016-11-29 01:25:14]

Patchset 3 (id:??) landed as
https://crrev.com/1acc2c4283c64636eb2a120f3e1e51267f74a427
Cr-Commit-Position: refs/heads/master@{#434811}