Issue 254243002: Revert 267030 "Build remoting for PNaCl"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254243002: Revert 267030 "Build remoting for PNaCl" (Closed)

Created:
6 years, 7 months ago by Sergey Ulanov

Modified:
6 years, 7 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 267030 "Build remoting for PNaCl" > Build remoting for PNaCl > > BUG=276739 > R=jamiewalch@chromium.org > > Review URL: https://codereview.chromium.org/234023003 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267064

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -417 lines)			Patch
M	trunk/src/jingle/jingle_nacl.gyp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/src/remoting/client/plugin/chromoting_instance.h	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/remoting/client/plugin/chromoting_instance.cc	View	6 chunks	+11 lines, -32 lines	0 comments	Download
D	trunk/src/remoting/client/plugin/pepper_module.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	trunk/src/remoting/protocol/jingle_session_unittest.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/remoting/protocol/libjingle_transport_factory.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	trunk/src/remoting/protocol/ssl_hmac_channel_authenticator.cc	View	4 chunks	+3 lines, -19 lines	0 comments	Download
M	trunk/src/remoting/remoting_client.gypi	View	2 chunks	+0 lines, -26 lines	0 comments	Download
D	trunk/src/remoting/remoting_nacl.gyp	View	1 chunk	+0 lines, -236 lines	0 comments	Download
M	trunk/src/remoting/remoting_webapp.gypi	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	trunk/src/remoting/webapp/build-webapp.py	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/src/remoting/webapp/client_session.js	View	1 chunk	+2 lines, -11 lines	0 comments	Download
M	trunk/src/remoting/webapp/manifest.json.jinja2	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	trunk/src/remoting/webapp/plugin_settings.js	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	trunk/src/remoting/webapp/remoting_client_pnacl.nmf	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	trunk/src/third_party/libwebm/libwebm_nacl.gyp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

6 years, 7 months ago (2014-04-30 04:41:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r267064 (tree was closed).

Expand Messages | Collapse Messages