Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: trunk/src/remoting/protocol/ssl_hmac_channel_authenticator.cc

Issue 254243002: Revert 267030 "Build remoting for PNaCl" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/remoting/protocol/libjingle_transport_factory.cc ('k') | trunk/src/remoting/remoting_client.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/remoting/protocol/ssl_hmac_channel_authenticator.cc
===================================================================
--- trunk/src/remoting/protocol/ssl_hmac_channel_authenticator.cc (revision 267063)
+++ trunk/src/remoting/protocol/ssl_hmac_channel_authenticator.cc (working copy)
@@ -15,7 +15,6 @@
#include "net/socket/client_socket_factory.h"
#include "net/socket/client_socket_handle.h"
#include "net/socket/ssl_client_socket.h"
-#include "net/socket/ssl_client_socket_openssl.h"
#include "net/socket/ssl_server_socket.h"
#include "net/ssl/ssl_config_service.h"
#include "remoting/base/rsa_key_pair.h"
@@ -64,12 +63,6 @@
int result;
if (is_ssl_server()) {
-#if defined(OS_NACL)
- // Client plugin doesn't use server SSL sockets, and so SSLServerSocket
- // implementation is not compiled for NaCl as part of net_nacl.
- NOTREACHED();
- result = net::ERR_FAILED;
-#else
scoped_refptr<net::X509Certificate> cert =
net::X509Certificate::CreateFromBytes(
local_cert_.data(), local_cert_.length());
@@ -92,7 +85,6 @@
result = raw_server_socket->Handshake(
base::Bind(&SslHmacChannelAuthenticator::OnConnected,
base::Unretained(this)));
-#endif
} else {
transport_security_state_.reset(new net::TransportSecurityState);
@@ -112,19 +104,11 @@
net::HostPortPair host_and_port(kSslFakeHostName, 0);
net::SSLClientSocketContext context;
context.transport_security_state = transport_security_state_.get();
- scoped_ptr<net::ClientSocketHandle> socket_handle(
- new net::ClientSocketHandle);
- socket_handle->SetSocket(socket.Pass());
-
-#if defined(OS_NACL)
- // net_nacl doesn't include ClientSocketFactory.
- socket_.reset(new net::SSLClientSocketOpenSSL(
- socket_handle.Pass(), host_and_port, ssl_config, context));
-#else
+ scoped_ptr<net::ClientSocketHandle> connection(new net::ClientSocketHandle);
+ connection->SetSocket(socket.Pass());
socket_ =
net::ClientSocketFactory::GetDefaultFactory()->CreateSSLClientSocket(
- socket_handle.Pass(), host_and_port, ssl_config, context);
-#endif
+ connection.Pass(), host_and_port, ssl_config, context);
result = socket_->Connect(
base::Bind(&SslHmacChannelAuthenticator::OnConnected,
« no previous file with comments | « trunk/src/remoting/protocol/libjingle_transport_factory.cc ('k') | trunk/src/remoting/remoting_client.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698