Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2542273002: Ensure that BBR does not drop to exceedingly low pacing rates during the STARTUP phase. Protected … (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that BBR does not drop to exceedingly low pacing rates during the STARTUP phase. Protected by FLAGS_quic_bbr_faster_startup. This is ensured in two ways: - The pacing rate is never decreased during the STARTUP phase. - The pacing rate is set to be at least initial_window / min_rtt. Merge internal change: 140102880 BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -3 lines) Patch
M net/quic/core/congestion_control/bbr_sender.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender.cc View 2 chunks +21 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender_test.cc View 3 chunks +34 lines, -1 line 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +3 lines, -0 lines 2 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
Ryan Hamilton
4 years ago (2016-12-01 21:15:58 UTC) #2
Zhongyi Shi
lgtm https://codereview.chromium.org/2542273002/diff/1/net/quic/core/quic_flags_list.h File net/quic/core/quic_flags_list.h (right): https://codereview.chromium.org/2542273002/diff/1/net/quic/core/quic_flags_list.h#newcode153 net/quic/core/quic_flags_list.h:153: QUIC_FLAG(bool, FLAGS_quic_bbr_faster_startup, true) Please make sure the default ...
4 years ago (2016-12-01 22:45:46 UTC) #3
Zhongyi Shi
4 years ago (2016-12-01 22:51:45 UTC) #4
https://codereview.chromium.org/2542273002/diff/1/net/quic/core/quic_flags_li...
File net/quic/core/quic_flags_list.h (right):

https://codereview.chromium.org/2542273002/diff/1/net/quic/core/quic_flags_li...
net/quic/core/quic_flags_list.h:153: QUIC_FLAG(bool,
FLAGS_quic_bbr_faster_startup, true)
On 2016/12/01 22:45:46, Zhongyi Shi wrote:
> Please make sure the default value is correct since the internal is still off.

okay, it's flipped to false in the flag flip cl.

Powered by Google App Engine
This is Rietveld 408576698