net/quic/core/quic_flags_list.h - Issue 2542273002: Ensure that BBR does not drop to exceedingly low pacing rates during the STARTUP phase. Protected …

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/quic/core/quic_flags_list.h

Issue 2542273002: Ensure that BBR does not drop to exceedingly low pacing rates during the STARTUP phase. Protected … (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « net/quic/core/congestion_control/bbr_sender_test.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // This file intentionally does not have header guards, it's included	5 // This file intentionally does not have header guards, it's included

6 // inside a macro to generate values.	6 // inside a macro to generate values.

7	7

8 // This file contains the list of QUIC protocol flags.	8 // This file contains the list of QUIC protocol flags.

9	9

10 // If true, QUIC BBR congestion control may be enabled via Finch and/or via QUIC	10 // If true, QUIC BBR congestion control may be enabled via Finch and/or via QUIC

(...skipping 130 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
141 // help.	141 // help.

142 QUIC_FLAG(bool, FLAGS_quic_fix_version_manager, false)	142 QUIC_FLAG(bool, FLAGS_quic_fix_version_manager, false)

143	143

144 // Add a new client connection options field to QuicOptions which is only used	144 // Add a new client connection options field to QuicOptions which is only used

145 // to configure client side features, such as congestion control.	145 // to configure client side features, such as congestion control.

146 QUIC_FLAG(bool, FLAGS_quic_client_connection_options, true)	146 QUIC_FLAG(bool, FLAGS_quic_client_connection_options, true)

147	147

148 // If true, fix some casts that were causing off-by-one errors in QUIC's cubic	148 // If true, fix some casts that were causing off-by-one errors in QUIC's cubic

149 // "convex" increases.	149 // "convex" increases.

150 QUIC_FLAG(bool, FLAGS_quic_fix_cubic_convex_mode, true)	150 QUIC_FLAG(bool, FLAGS_quic_fix_cubic_convex_mode, true)

	151

	152 // Ensure that BBR startup pacing rate does not drop below the initial one.

	153 QUIC_FLAG(bool, FLAGS_quic_bbr_faster_startup, true)
	Zhongyi Shi 2016/12/01 22:45:46 Please make sure the default value is correct sinc Please make sure the default value is correct since the internal is still off. Zhongyi Shi 2016/12/01 22:51:44 okay, it's flipped to false in the flag flip cl. Show quoted text On 2016/12/01 22:45:46, Zhongyi Shi wrote: > Please make sure the default value is correct since the internal is still off. okay, it's flipped to false in the flag flip cl.
OLD	NEW