chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc - Issue 2542093002: [Password Generation] Fixes sending votes about the usage of the password generation popup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

Issue 2542093002: [Password Generation] Fixes sending votes about the usage of the password generation popup (Closed)

Patch Set: Changes addressed to reviewer comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('j') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

index 370731a7ea41f70104b7f9083caf7d1dda339ec0..3b9b89eed78153e9dba2777b97a157deb88c539f 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

@@ -256,6 +256,7 @@ TEST_F(ManagePasswordsBubbleModelTest, CloseWithoutInteraction) {

stats.dismissal_count++;

stats.update_time = now;

EXPECT_CALL(*GetStore(), AddSiteStatsImpl(stats));

+ EXPECT_CALL(*controller(), OnNoInteraction());

EXPECT_CALL(*controller(), SavePassword()).Times(0);

EXPECT_CALL(*controller(), NeverSavePassword()).Times(0);

DestroyModelExpectReason(

@@ -330,6 +331,7 @@ TEST_F(ManagePasswordsBubbleModelTest, ShowSmartLockWarmWelcome) {

EXPECT_TRUE(model()->ShouldShowGoogleSmartLockWelcome());

EXPECT_CALL(*GetStore(), AddSiteStatsImpl(_));

+ EXPECT_CALL(*controller(), OnNoInteraction());

DestroyModel();

PretendPasswordWaiting();

@@ -350,6 +352,7 @@ TEST_F(ManagePasswordsBubbleModelTest, OmitSmartLockWarmWelcome) {

EXPECT_FALSE(model()->ShouldShowGoogleSmartLockWelcome());

EXPECT_CALL(*GetStore(), AddSiteStatsImpl(_));

+ EXPECT_CALL(*controller(), OnNoInteraction());

DestroyModel();

PretendPasswordWaiting();