[Password Generation] Fixes sending votes about the usage of the password generation popup

chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/memory/ptr_util.h"
@@ skipping 238 matching lines @@
 
   EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_STATE, model()->state());
   std::unique_ptr<base::SimpleTestClock> clock(new base::SimpleTestClock);
   base::Time now = base::Time::Now();
   clock->SetNow(now);
   model()->SetClockForTesting(std::move(clock));
   password_manager::InteractionsStats stats = GetTestStats();
   stats.dismissal_count++;
   stats.update_time = now;
   EXPECT_CALL(*GetStore(), AddSiteStatsImpl(stats));
+  EXPECT_CALL(*controller(), OnNoInteraction());
   EXPECT_CALL(*controller(), SavePassword()).Times(0);
   EXPECT_CALL(*controller(), NeverSavePassword()).Times(0);
   DestroyModelExpectReason(
       password_manager::metrics_util::NO_DIRECT_INTERACTION);
 }
 
 TEST_F(ManagePasswordsBubbleModelTest, ClickSave) {
   PretendPasswordWaiting();
 
   EXPECT_CALL(*GetStore(), RemoveSiteStatsImpl(GURL(kSiteOrigin).GetOrigin()));
@@ skipping 54 matching lines @@
       ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(
           profile(), &TestingSyncFactoryFunction));
   sync_service->set_smartlock_enabled(true);
   base::FieldTrialList::CreateFieldTrial(kBrandingExperimentName,
                                          kSmartLockBrandingGroupName);
 
   PretendPasswordWaiting();
 
   EXPECT_TRUE(model()->ShouldShowGoogleSmartLockWelcome());
   EXPECT_CALL(*GetStore(), AddSiteStatsImpl(_));
+  EXPECT_CALL(*controller(), OnNoInteraction());
   DestroyModel();
   PretendPasswordWaiting();
 
   EXPECT_FALSE(model()->ShouldShowGoogleSmartLockWelcome());
   EXPECT_TRUE(prefs()->GetBoolean(
       password_manager::prefs::kWasSavePrompFirstRunExperienceShown));
 }
 
 TEST_F(ManagePasswordsBubbleModelTest, OmitSmartLockWarmWelcome) {
   TestSyncService* sync_service = static_cast<TestSyncService*>(
       ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(
           profile(), &TestingSyncFactoryFunction));
   sync_service->set_smartlock_enabled(false);
   base::FieldTrialList::CreateFieldTrial(kBrandingExperimentName,
                                          kSmartLockBrandingGroupName);
 
   PretendPasswordWaiting();
 
   EXPECT_FALSE(model()->ShouldShowGoogleSmartLockWelcome());
   EXPECT_CALL(*GetStore(), AddSiteStatsImpl(_));
+  EXPECT_CALL(*controller(), OnNoInteraction());
   DestroyModel();
   PretendPasswordWaiting();
 
   EXPECT_FALSE(model()->ShouldShowGoogleSmartLockWelcome());
   EXPECT_FALSE(prefs()->GetBoolean(
       password_manager::prefs::kWasSavePrompFirstRunExperienceShown));
 }
 
 TEST_F(ManagePasswordsBubbleModelTest, OnBrandLinkClicked) {
   PretendPasswordWaiting();
@@ skipping 211 matching lines @@
      ManageLinkTarget::SETTINGS_PAGE},
     {nullptr, SmartLockStatus::DISABLE, ManageLinkTarget::SETTINGS_PAGE},
     {"Default", SmartLockStatus::DISABLE, ManageLinkTarget::SETTINGS_PAGE},
 };
 
 }  // namespace
 
 INSTANTIATE_TEST_CASE_P(Default,
                         ManagePasswordsBubbleModelManageLinkTest,
                         ::testing::ValuesIn(kManageLinkTestCases));