Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2542063002: Clarify that InfoBar.Shown increments on tab switch on desktop. (Closed)

Created:
4 years ago by dominickn
Modified:
4 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify that InfoBar.Shown increments on tab switch on desktop. BUG=None Committed: https://crrev.com/3f8531a6ce449fd43f3f904867f019b4b12d70cd Cr-Commit-Position: refs/heads/master@{#435558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
dominickn
PTAL, thanks!
4 years ago (2016-12-01 03:07:18 UTC) #4
dominickn
PTAL, thanks!
4 years ago (2016-12-01 03:07:19 UTC) #5
Ilya Sherman
LGTM, thanks.
4 years ago (2016-12-01 05:08:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2542063002/1
4 years ago (2016-12-01 05:09:15 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 05:13:50 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 05:16:59 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f8531a6ce449fd43f3f904867f019b4b12d70cd
Cr-Commit-Position: refs/heads/master@{#435558}

Powered by Google App Engine
This is Rietveld 408576698