Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2541993002: Add GMS to WebView build (Closed)

Created:
4 years ago by paulmiller
Modified:
4 years ago
Reviewers:
michaelbai
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GMS to WebView build This grows standalone WebView APKs by ~1MB. Ameliorating the growth is tracked in the same bug. BUG=662166 Committed: https://crrev.com/cbdf89edbceb0d74f97c86fcb6831d4e136b119b Cr-Commit-Position: refs/heads/master@{#436097}

Patch Set 1 #

Patch Set 2 : add tryEnableGms function #

Patch Set 3 : fix proguard failure, add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M android_webview/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/apk/java/proguard.flags View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
paulmiller
On 2016/11/30 22:20:29, paulmiller wrote: > mailto:paulmiller@chromium.org changed reviewers: > + mailto:sgurun@chromium.org PTAL
4 years ago (2016-11-30 22:20:49 UTC) #3
paulmiller
On 2016/11/30 22:20:49, paulmiller wrote: > On 2016/11/30 22:20:29, paulmiller wrote: > > mailto:paulmiller@chromium.org changed ...
4 years ago (2016-12-01 20:44:58 UTC) #5
paulmiller
On 2016/12/01 20:44:58, paulmiller wrote: > On 2016/11/30 22:20:49, paulmiller wrote: > > On 2016/11/30 ...
4 years ago (2016-12-02 21:07:24 UTC) #9
michaelbai
lgtm
4 years ago (2016-12-02 21:19:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541993002/40001
4 years ago (2016-12-02 21:21:19 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-03 00:24:41 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-03 00:26:06 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cbdf89edbceb0d74f97c86fcb6831d4e136b119b
Cr-Commit-Position: refs/heads/master@{#436097}

Powered by Google App Engine
This is Rietveld 408576698