android_webview/apk/java/proguard.flags - Issue 2541993002: Add GMS to WebView build

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/apk/java/proguard.flags

Issue 2541993002: Add GMS to WebView build (Closed)

Patch Set: fix proguard failure, add comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « android_webview/BUILD.gn ('k') | android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java » ('j') | no next file with comments »

OLD	NEW
1 # Don't rename anything, it makes stack traces unintelligible. We only allow the	1 # Don't rename anything, it makes stack traces unintelligible. We only allow the

2 # obfuscation pass to run so that we can discard attributes like local variable	2 # obfuscation pass to run so that we can discard attributes like local variable

3 # tables. However, we don't want to lose out on optimizations, so although they	3 # tables. However, we don't want to lose out on optimizations, so although they

4 # can occasionally make the stack trace a bit stranger with inlining, it won't	4 # can occasionally make the stack trace a bit stranger with inlining, it won't

5 # make a big difference for the users seeing the stacktraces. We can always use	5 # make a big difference for the users seeing the stacktraces. We can always use

6 # build/android/stacktrace/java_deobfuscate.py to fix the stacktrace up for us.	6 # build/android/stacktrace/java_deobfuscate.py to fix the stacktrace up for us.

7 -keepnames,allowoptimization class *** { *; }	7 -keepnames,allowoptimization class *** { *; }

8	8

9 # Keep the factory and its public members; it's the main entry point used by the	9 # Keep the factory and its public members; it's the main entry point used by the

10 # framework.	10 # framework.

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56 void setMetricsSettingListener(...);	56 void setMetricsSettingListener(...);

57 PlatformServiceBridgeGoogle(...);	57 PlatformServiceBridgeGoogle(...);

58 }	58 }

59 -dontnote com.android.webview.chromium.PlatformServiceBridgeGoogle	59 -dontnote com.android.webview.chromium.PlatformServiceBridgeGoogle

60	60

61 #TODO(hush): remove after N release. crbug.com/546762	61 #TODO(hush): remove after N release. crbug.com/546762

62 -keep class com.android.webview.chromium.ContentSettingsAdapter {	62 -keep class com.android.webview.chromium.ContentSettingsAdapter {

63 public void setDisabledActionModeMenuItems(int);	63 public void setDisabledActionModeMenuItems(int);

64 public int getDisabledActionModeMenuItems();	64 public int getDisabledActionModeMenuItems();

65 }	65 }

	66

	67 # We strip some unused resources when preprocessing the GMS client libs.

	68 -dontwarn com.google.android.gms.R**

OLD	NEW