Stop using Element.unit directly.

Stop using Element.unit directly.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/2537784f9282cc7822a5ec593d992a0cd1f45d77

[Brian Wilkerson, 2016-11-30 17:03:52]

Are we doing this because 'unit' isn't async and therefore doesn't work with the
AnalysisDriver? If that's the case, should we deprecate 'unit' (possibly as a
future CL)?

https://codereview.chromium.org/2541873002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
(right):

https://codereview.chromium.org/2541873002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart:128:
CompilationUnit refUnit = await getResolvedUnit(refElement);
This appears to assume that getResolvedUnit is non-null, but 'null' is being
passed in where this class' constructor is called.

[scheglov, 2016-11-30 17:11:31]

Yes, I'd like to remove Element.unit and Element.computeNode. This is in line
with the work Paul is doing to separate elements and context. And yes, to be
able to use the new driver to perform resolution.

https://codereview.chromium.org/2541873002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
(right):

https://codereview.chromium.org/2541873002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart:128:
CompilationUnit refUnit = await getResolvedUnit(refElement);
On 2016/11/30 17:03:52, Brian Wilkerson wrote:
> This appears to assume that getResolvedUnit is non-null, but 'null' is being
> passed in where this class' constructor is called.

Acknowledged.
We call it with "null" at the place where we call only checkInitialConditions(),
so we don't actually need getResolvedUnit. I will replace it with not-null
throwing StateError.

[Brian Wilkerson, 2016-11-30 17:17:51]

https://codereview.chromium.org/2541873002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
(right):

https://codereview.chromium.org/2541873002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart:128:
CompilationUnit refUnit = await getResolvedUnit(refElement);
Or just pass in a non-null value, since it is readily available and won't do any
harm. Then we guard against future problems if we change the code in this class
to start calling it at other times.

[scheglov, 2016-11-30 17:24:04]

PTAL

https://codereview.chromium.org/2541873002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
(right):

https://codereview.chromium.org/2541873002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart:128:
CompilationUnit refUnit = await getResolvedUnit(refElement);
On 2016/11/30 17:17:51, Brian Wilkerson wrote:
> Or just pass in a non-null value, since it is readily available and won't do
any
> harm. Then we guard against future problems if we change the code in this
class
> to start calling it at other times.

Done.

[Brian Wilkerson, 2016-11-30 17:34:18]

lgtm

https://codereview.chromium.org/2541873002/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/2541873002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/edit/edit_domain.dart:409: throw new
StateError('Unexpected resolved unit request.'),
I guess this is fine, but I was thinking of passing a non-exception-throwing
function in here.

On closer inspection, however, I see that you don't have ready access to such a
function. You'd either have to duplicate '_getResolvedUnit' (from line 690) or
create a global utility method such as

GetResolvedUnit getResolvedUnitGetter(AnalysisServer server) => (Element
element) {
  String path = element.source.fullName;
  return server.getResolvedCompilationUnit(path);
};

Probably not worth it.

[scheglov, 2016-11-30 17:38:00]

Description was changed from

==========
Stop using Element.unit directly.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Stop using Element.unit directly.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/2537784f9282cc7822a5ec593d992a0cd1f45d77
==========

[scheglov, 2016-11-30 17:38:01]

Committed patchset #2 (id:20001) manually as
2537784f9282cc7822a5ec593d992a0cd1f45d77 (presubmit successful).