Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart

Issue 2541873002: Stop using Element.unit directly. (Closed)
Patch Set: tweak Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart b/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
index b742612c9f8e547c23b4c871874dc4027e86ce1c..e8ef23c69d4556e89177d1f2ab4f01e219b4ff40 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
@@ -24,11 +24,13 @@ import 'package:analyzer/src/generated/source.dart';
class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl
implements ConvertMethodToGetterRefactoring {
final SearchEngine searchEngine;
+ final GetResolvedUnit getResolvedUnit;
final ExecutableElement element;
SourceChange change;
- ConvertMethodToGetterRefactoringImpl(this.searchEngine, this.element);
+ ConvertMethodToGetterRefactoringImpl(
+ this.searchEngine, this.getResolvedUnit, this.element);
@override
String get refactoringName => 'Convert Method To Getter';
@@ -114,7 +116,7 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl
}
}
- Future _updateElementReferences(Element element) async {
+ Future<Null> _updateElementReferences(Element element) async {
List<SearchMatch> matches = await searchEngine.searchReferences(element);
List<SourceReference> references = getSourceReferences(matches);
for (SourceReference reference in references) {
@@ -123,7 +125,7 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl
// prepare invocation
MethodInvocation invocation;
{
- CompilationUnit refUnit = refElement.unit;
+ CompilationUnit refUnit = await getResolvedUnit(refElement);
AstNode refNode =
new NodeLocator(refRange.offset).searchWithin(refUnit);
invocation = refNode.getAncestor((node) => node is MethodInvocation);

Powered by Google App Engine
This is Rietveld 408576698