Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2541803003: media: remove unused functions: Renderer::HasAudio()/HasVideo() (Closed)

Created:
4 years ago by watk
Modified:
4 years ago
Reviewers:
xhwang, halliwell
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, chromoting-reviews_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, apacible+watch_chromium.org, alokp+watch_chromium.org, darin (slow to review), miu+watch_chromium.org, xjz+watch_chromium.org, Aaron Boodman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: remove unused functions: Renderer::HasAudio()/HasVideo() These are unused so now they're gone. BUG=670420 TEST=compiles Committed: https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb Cr-Commit-Position: refs/heads/master@{#435716}

Patch Set 1 #

Patch Set 2 : andriod ones #

Patch Set 3 : cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -105 lines) Patch
M chromecast/media/service/cast_renderer.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/media/service/cast_renderer.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/media/android/media_player_renderer.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/media/android/media_player_renderer.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/media/android/media_player_renderer_client.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/android/media_player_renderer_client.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M media/base/renderer.h View 1 chunk +0 lines, -6 lines 0 comments Download
M media/mojo/clients/mojo_renderer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/mojo/clients/mojo_renderer.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M media/remoting/remote_renderer_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/remoting/remote_renderer_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M media/renderers/renderer_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/renderers/renderer_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
watk
PTAL. Any reason to keep these?
4 years ago (2016-12-01 01:12:51 UTC) #10
xhwang
LGTM This was used to report MetaData, e.t. https://codereview.chromium.org/418143005 metadata.has_audio = renderer_->HasAudio(); metadata.has_video = renderer_->HasVideo(); ...
4 years ago (2016-12-01 02:58:21 UTC) #11
watk
Ah gotcha, thanks!
4 years ago (2016-12-01 19:57:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541803003/40001
4 years ago (2016-12-01 19:58:34 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/316642)
4 years ago (2016-12-01 20:07:01 UTC) #16
watk
halliwell@chromium.org: Please review changes in chromecast/
4 years ago (2016-12-01 20:13:06 UTC) #19
halliwell
On 2016/12/01 20:13:06, watk wrote: > mailto:halliwell@chromium.org: Please review changes in chromecast/ chromecast/ lgtm
4 years ago (2016-12-01 21:13:11 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541803003/40001
4 years ago (2016-12-01 21:19:22 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-01 21:25:08 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-01 21:29:26 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/57a95b6adf89949133e7947cc313d6de2b8c8bcb
Cr-Commit-Position: refs/heads/master@{#435716}

Powered by Google App Engine
This is Rietveld 408576698