Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: content/renderer/media/android/media_player_renderer_client.cc

Issue 2541803003: media: remove unused functions: Renderer::HasAudio()/HasVideo() (Closed)
Patch Set: cast Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/android/media_player_renderer_client.h" 5 #include "content/renderer/media/android/media_player_renderer_client.h"
6 6
7 #include "base/callback_helpers.h" 7 #include "base/callback_helpers.h"
8 8
9 namespace content { 9 namespace content {
10 10
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 } 97 }
98 98
99 void MediaPlayerRendererClient::SetVolume(float volume) { 99 void MediaPlayerRendererClient::SetVolume(float volume) {
100 mojo_renderer_->SetVolume(volume); 100 mojo_renderer_->SetVolume(volume);
101 } 101 }
102 102
103 base::TimeDelta MediaPlayerRendererClient::GetMediaTime() { 103 base::TimeDelta MediaPlayerRendererClient::GetMediaTime() {
104 return mojo_renderer_->GetMediaTime(); 104 return mojo_renderer_->GetMediaTime();
105 } 105 }
106 106
107 bool MediaPlayerRendererClient::HasAudio() {
108 // We do not know whether or not the media has Audio before starting playback.
109 // Conservatively assume we do.
110 // TODO(tguilbert): Consider using MIME types to determine presence of audio.
111 // Alternatively, consider piping the HasAudio() from the MediaPlayerRenderer
112 // through the mojo::Renderer interface.
113 return true;
114 }
115
116 bool MediaPlayerRendererClient::HasVideo() {
117 // We do not know whether or not the media has Video before starting playback.
118 // Conservatively assume we do.
119 // TODO(tguilbert): Consider using MIME types to determine presence of video.
120 // Alternatively, consider piping the HasVideo() from the MediaPlayerRenderer
121 // through the mojo::Renderer interface.
122 return true;
123 }
124
125 void MediaPlayerRendererClient::OnFrameAvailable() { 107 void MediaPlayerRendererClient::OnFrameAvailable() {
126 DCHECK(compositor_task_runner_->BelongsToCurrentThread()); 108 DCHECK(compositor_task_runner_->BelongsToCurrentThread());
127 sink_->PaintSingleFrame(stream_texture_wrapper_->GetCurrentFrame(), true); 109 sink_->PaintSingleFrame(stream_texture_wrapper_->GetCurrentFrame(), true);
128 } 110 }
129 111
130 void MediaPlayerRendererClient::OnError(media::PipelineStatus status) { 112 void MediaPlayerRendererClient::OnError(media::PipelineStatus status) {
131 client_->OnError(status); 113 client_->OnError(status);
132 } 114 }
133 115
134 void MediaPlayerRendererClient::OnEnded() { 116 void MediaPlayerRendererClient::OnEnded() {
(...skipping 22 matching lines...) Expand all
157 139
158 void MediaPlayerRendererClient::OnVideoOpacityChange(bool opaque) { 140 void MediaPlayerRendererClient::OnVideoOpacityChange(bool opaque) {
159 client_->OnVideoOpacityChange(opaque); 141 client_->OnVideoOpacityChange(opaque);
160 } 142 }
161 143
162 void MediaPlayerRendererClient::OnDurationChange(base::TimeDelta duration) { 144 void MediaPlayerRendererClient::OnDurationChange(base::TimeDelta duration) {
163 client_->OnDurationChange(duration); 145 client_->OnDurationChange(duration);
164 } 146 }
165 147
166 } // namespace content 148 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/media/android/media_player_renderer_client.h ('k') | media/base/pipeline_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698