DevTools: Filter text input cuts off user's filter string

DevTools: Filter text input cuts off user's filter string

In the Network panel DevTools cuts off user's fileter string in case some part of it was selected.


BUG=669400
TEST=https://bugs.chromium.org/p/chromium/issues/detail?id=669400

[Oleksii Kadurin, 2016-11-30 08:08:29]

The CQ bit was checked by ovkadurin@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 08:09:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 08:09:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 08:09:10]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Oleksii Kadurin, 2016-11-30 08:17:12]

Description was changed from

==========
DevTools: Filter text input cuts off user's filter string

In the Network panel DevTools cuts off user's fileter string in case some part
of it was selected.


BUG=669400
TEST=https://bugs.chromium.org/p/chromium/issues/detail?id=669400
==========

to

==========
DevTools: Filter text input cuts off user's filter string

In the Network panel DevTools cuts off user's fileter string in case some part
of it was selected.


BUG=669400
TEST=https://bugs.chromium.org/p/chromium/issues/detail?id=669400
==========

[Oleksii Kadurin, 2016-11-30 08:17:13]

ovkadurin@gmail.com changed reviewers:
+ chenwilliam@chromium.com, pfeldman@chromium.com

[Oleksii Kadurin, 2016-11-30 08:20:09]

Hi! Please review my changes.

[chenwilliam, 2016-12-01 18:57:32]

chenwilliam@chromium.org changed reviewers:
+ allada@chromium.org, lushnikov@chromium.org
- pfeldman@chromium.com

[chenwilliam, 2016-12-01 18:59:48]

chenwilliam@chromium.org changed reviewers:
+ chenwilliam@chromium.org

[chenwilliam, 2016-12-01 18:59:49]

@lushnikov and @allada, I've added you as reviewers since you've recently worked
on this file.

[chenwilliam, 2016-12-01 21:12:09]

chenwilliam@chromium.org changed reviewers:
- chenwilliam@chromium.com

[allada, 2016-12-01 22:37:55]

On 2016/12/01 18:59:49, chenwilliam wrote:
> @lushnikov and @allada, I've added you as reviewers since you've recently
worked
> on this file.

Thanks for the patch! However I already landed a patch yesterday
that fixed this: https://codereview.chromium.org/2535203004/

Thanks again!

[Oleksii Kadurin, 2016-12-01 23:28:31]

On 2016/12/01 22:37:55, Blaise wrote:
> On 2016/12/01 18:59:49, chenwilliam wrote:
> > @lushnikov and @allada, I've added you as reviewers since you've recently
> worked
> > on this file.
> 
> Thanks for the patch! However I already landed a patch yesterday
> that fixed this: https://codereview.chromium.org/2535203004/
> 
> Thanks again!

Hi! Thanks for reply. I've just compared you patch and mine. It's almost the
same except one additional piece of code in my patch.
If you are interested in that I can write here tomorrow what case I was trying
to avoid using that piece of code.

[allada, 2016-12-02 02:44:24]

On 2016/12/01 23:28:31, Oleksii Kadurin wrote:
> On 2016/12/01 22:37:55, Blaise wrote:
> > On 2016/12/01 18:59:49, chenwilliam wrote:
> > > @lushnikov and @allada, I've added you as reviewers since you've recently
> > worked
> > > on this file.
> > 
> > Thanks for the patch! However I already landed a patch yesterday
> > that fixed this: https://codereview.chromium.org/2535203004/
> > 
> > Thanks again!
> 
> Hi! Thanks for reply. I've just compared you patch and mine. It's almost the
> same except one additional piece of code in my patch.
> If you are interested in that I can write here tomorrow what case I was trying
> to avoid using that piece of code.

Yes I noticed that code difference, but was not able to come to a reason on why
we would not want to hide the suggestion box when the value changed.

[Oleksii Kadurin, 2016-12-02 08:20:25]

On 2016/12/02 02:44:24, Blaise wrote:
> On 2016/12/01 23:28:31, Oleksii Kadurin wrote:
> > On 2016/12/01 22:37:55, Blaise wrote:
> > > On 2016/12/01 18:59:49, chenwilliam wrote:
> > > > @lushnikov and @allada, I've added you as reviewers since you've
recently
> > > worked
> > > > on this file.
> > > 
> > > Thanks for the patch! However I already landed a patch yesterday
> > > that fixed this: https://codereview.chromium.org/2535203004/
> > > 
> > > Thanks again!
> > 
> > Hi! Thanks for reply. I've just compared you patch and mine. It's almost the
> > same except one additional piece of code in my patch.
> > If you are interested in that I can write here tomorrow what case I was
trying
> > to avoid using that piece of code.
> 
> Yes I noticed that code difference, but was not able to come to a reason on
why
> we would not want to hide the suggestion box when the value changed.

Hi! I recall why I made that additional piece of code.
Check out the animated gif in here:
https://drive.google.com/file/d/0ByC_JXfGJgxcRjZnWkpFbjF6VUU/view?usp=sharing
So your changes fix the ticket's issue, but it breaks suggestion disappearing.

[allada, 2016-12-08 21:27:28]

On 2016/12/02 08:20:25, Oleksii Kadurin wrote:
> On 2016/12/02 02:44:24, Blaise wrote:
> > On 2016/12/01 23:28:31, Oleksii Kadurin wrote:
> > > On 2016/12/01 22:37:55, Blaise wrote:
> > > > On 2016/12/01 18:59:49, chenwilliam wrote:
> > > > > @lushnikov and @allada, I've added you as reviewers since you've
> recently
> > > > worked
> > > > > on this file.
> > > > 
> > > > Thanks for the patch! However I already landed a patch yesterday
> > > > that fixed this: https://codereview.chromium.org/2535203004/
> > > > 
> > > > Thanks again!
> > > 
> > > Hi! Thanks for reply. I've just compared you patch and mine. It's almost
the
> > > same except one additional piece of code in my patch.
> > > If you are interested in that I can write here tomorrow what case I was
> trying
> > > to avoid using that piece of code.
> > 
> > Yes I noticed that code difference, but was not able to come to a reason on
> why
> > we would not want to hide the suggestion box when the value changed.
> 
> Hi! I recall why I made that additional piece of code.
> Check out the animated gif in here:
> https://drive.google.com/file/d/0ByC_JXfGJgxcRjZnWkpFbjF6VUU/view?usp=sharing
> So your changes fix the ticket's issue, but it breaks suggestion disappearing.

There was a patch recently that was pushed through that should have fixed both
issues.

https://codereview.chromium.org/2545983002/

I am going to close the issue to get it out of our list, but thank you very much
for the patch!