Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

Issue 2541793002: DevTools: Filter text input cuts off user's filter string (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
index b54e5c90aef91e29fe3dd247b909cdc80f026c82..811f8fe1452d5358890a26795416727e7ed1c899 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
@@ -289,7 +289,7 @@ UI.TextFilterUI = class extends Common.Object {
}
_cancelSuggestion() {
- if (this._suggestionBuilder && this._suggestBox.visible) {
+ if (this._suggestionBuilder && this._suggestBox.visible()) {
this._suggestionBuilder.unapplySuggestion(this._filterInputElement);
this._suggestBox.hide();
}
@@ -342,8 +342,6 @@ UI.TextFilterUI = class extends Common.Object {
_valueChanged(showSuggestions) {
if (showSuggestions)
this._updateSuggestions();
- else
- this._suggestBox.hide();
var filterQuery = this.value();
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698