chrome/android/java/res/layout/psl_info_tooltip.xml - Issue 2541693004: Add Information Tooltip for Public Suffix List Matches

Unified Diff: chrome/android/java/res/layout/psl_info_tooltip.xml

Issue 2541693004: Add Information Tooltip for Public Suffix List Matches (Closed)

Patch Set: Addressed new set of comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/android/java/res/layout/account_chooser_dialog_item.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/res/values/dimens.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/psl_info_tooltip.xml

diff --git a/chrome/android/java/res/layout/psl_info_tooltip.xml b/chrome/android/java/res/layout/psl_info_tooltip.xml

new file mode 100644

index 0000000000000000000000000000000000000000..0390f9b9f79db340c2171222687fbed60ea57ab0

--- /dev/null

+++ b/chrome/android/java/res/layout/psl_info_tooltip.xml

@@ -0,0 +1,25 @@

+<?xml version="1.0" encoding="utf-8"?>

gone 2016/12/13 23:14:30 Can you name this (and all related things) somethi

jdoerrie 2016/12/15 13:27:18 Done.

+ Use of this source code is governed by a BSD-style license that can be

+ found in the LICENSE file. -->

+<LinearLayout

+ xmlns:android="http://schemas.android.com/apk/res/android"

gone 2016/12/13 23:14:30 indent by 4s not 2s; check the XML file above

jdoerrie 2016/12/15 13:27:18 Done.

+ android:id="@+id/psl_info_tooltip"

+ android:background="@drawable/psl_info_tooltip_background"

+ android:orientation="horizontal"

+ android:layout_width="fill_parent"

gone 2016/12/13 23:14:30 fill_parent is deprecated; use match_parent

jdoerrie 2016/12/15 13:27:18 Acknowledged.

+ android:layout_height="fill_parent">

gone 2016/12/13 23:14:30 layout params at top

jdoerrie 2016/12/15 13:27:18 Acknowledged.

+ <TextView

+ android:id="@+id/psl_info_tooltip_text"

+ android:layout_height="@dimen/psl_info_tooltip_height"

gone 2016/12/13 23:14:30 I don't think you need the outer LinearLayout. Th

jdoerrie 2016/12/15 13:27:18 Done.

+ android:layout_marginEnd="@dimen/psl_info_tooltip_horizontal_padding"

+ android:layout_marginStart="@dimen/psl_info_tooltip_horizontal_padding"

+ android:layout_width="wrap_content"

+ android:ellipsize="start"

+ android:fontFamily="sans-serif"

+ android:gravity="center"

+ android:singleLine="true"

+ android:textColor="#fff"

gone 2016/12/13 23:14:30 android:textColor="@android:color/white"

jdoerrie 2016/12/15 13:27:18 Done.

+ android:textSize="@dimen/psl_info_tooltip_text_size"/>

+</LinearLayout>