chrome/android/java/res/layout/psl_info_tooltip.xml - Issue 2541693004: Add Information Tooltip for Public Suffix List Matches

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/psl_info_tooltip.xml

Issue 2541693004: Add Information Tooltip for Public Suffix List Matches (Closed)

Patch Set: Addressed new set of comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/account_chooser_dialog_item.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/res/values/dimens.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	gone 2016/12/13 23:14:30 Can you name this (and all related things) somethi Can you name this (and all related things) something generic, like material_tooltip.xml, material_tooltip_background.xml, etc? jdoerrie 2016/12/15 13:27:18 Done. Show quoted text On 2016/12/13 23:14:30, dfalcantara (check my queue) wrote: > Can you name this (and all related things) something generic, like > material_tooltip.xml, material_tooltip_background.xml, etc? Done.
	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"
	gone 2016/12/13 23:14:30 indent by 4s not 2s; check the XML file above indent by 4s not 2s; check the XML file above jdoerrie 2016/12/15 13:27:18 Done. Show quoted text On 2016/12/13 23:14:30, dfalcantara (check my queue) wrote: > indent by 4s not 2s; check the XML file above Done.
	8 android:id="@+id/psl_info_tooltip"

	9 android:background="@drawable/psl_info_tooltip_background"

	10 android:orientation="horizontal"

	11 android:layout_width="fill_parent"
	gone 2016/12/13 23:14:30 fill_parent is deprecated; use match_parent fill_parent is deprecated; use match_parent jdoerrie 2016/12/15 13:27:18 Acknowledged. Show quoted text On 2016/12/13 23:14:30, dfalcantara (check my queue) wrote: > fill_parent is deprecated; use match_parent Acknowledged.
	12 android:layout_height="fill_parent">
	gone 2016/12/13 23:14:30 layout params at top layout params at top jdoerrie 2016/12/15 13:27:18 Acknowledged. Show quoted text On 2016/12/13 23:14:30, dfalcantara (check my queue) wrote: > layout params at top Acknowledged.
	13 <TextView

	14 android:id="@+id/psl_info_tooltip_text"

	15 android:layout_height="@dimen/psl_info_tooltip_height"
	gone 2016/12/13 23:14:30 I don't think you need the outer LinearLayout. Th I don't think you need the outer LinearLayout. There's only one child here. jdoerrie 2016/12/15 13:27:18 Done. Show quoted text On 2016/12/13 23:14:30, dfalcantara (check my queue) wrote: > I don't think you need the outer LinearLayout. There's only one child here. Done.
	16 android:layout_marginEnd="@dimen/psl_info_tooltip_horizontal_padding"

	17 android:layout_marginStart="@dimen/psl_info_tooltip_horizontal_padding"

	18 android:layout_width="wrap_content"

	19 android:ellipsize="start"

	20 android:fontFamily="sans-serif"

	21 android:gravity="center"

	22 android:singleLine="true"

	23 android:textColor="#fff"
	gone 2016/12/13 23:14:30 android:textColor="@android:color/white" android:textColor="@android:color/white" jdoerrie 2016/12/15 13:27:18 Done. Show quoted text On 2016/12/13 23:14:30, dfalcantara (check my queue) wrote: > android:textColor="@android:color/white" Done.
	24 android:textSize="@dimen/psl_info_tooltip_text_size"/>

	25 </LinearLayout>

OLD	NEW