Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 2541693004: Add Information Tooltip for Public Suffix List Matches (Closed)
Patch Set: Addressed comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/android/java/res/layout/account_chooser_dialog_item.xml ('K') | « chrome/android/java/res/layout/account_chooser_dialog_item.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/values/dimens.xml
diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml
index c67cdbb7ec9db57918cdbf8150b5c0e59f9fecb3..d4847ad677389721fcc8993c13ed84851d9af87f 100644
--- a/chrome/android/java/res/values/dimens.xml
+++ b/chrome/android/java/res/values/dimens.xml
@@ -339,10 +339,19 @@
<!-- Account chooser dialog dimensions -->
<dimen name="account_chooser_dialog_margin">24dp</dimen>
- <dimen name="account_chooser_dialog_item_margin">20dp</dimen>
+ <dimen name="account_chooser_dialog_item_margin">24dp</dimen>
<dimen name="account_chooser_dialog_title_main_text_size">18sp</dimen>
<dimen name="account_chooser_dialog_title_descriptive_text_size">16sp</dimen>
+ <!-- Public Suffix List (PSL) info icon and tooltip dimensions -->
+ <dimen name="psl_info_icon_width">24dp</dimen>
+ <dimen name="psl_info_icon_height">24dp</dimen>
+ <dimen name="psl_info_icon_padding">4dp</dimen>
+ <dimen name="psl_info_tooltip_text_size">14sp</dimen>
+ <dimen name="psl_info_tooltip_horizontal_padding">16dp</dimen>
+ <dimen name="psl_info_tooltip_height">32dp</dimen>
+ <dimen name="psl_info_tooltip_margin">8dp</dimen>
+
<!-- Clear browsing data preferences dimensions -->
<dimen name="clear_browsing_data_checkbox_height">56dp</dimen>
« chrome/android/java/res/layout/account_chooser_dialog_item.xml ('K') | « chrome/android/java/res/layout/account_chooser_dialog_item.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/password_manager/AccountChooserDialog.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698