Add Information Tooltip for Public Suffix List Matches

chrome/android/java/res/layout/account_chooser_dialog_item.xml

Index: chrome/android/java/res/layout/account_chooser_dialog_item.xml
diff --git a/chrome/android/java/res/layout/account_chooser_dialog_item.xml b/chrome/android/java/res/layout/account_chooser_dialog_item.xml
index 41875eca79a4c77c33d5a6b6f413688a9f7a003f..c53a4f752475b79ab0ddd785c51d61e3eab7d153 100644
--- a/chrome/android/java/res/layout/account_chooser_dialog_item.xml
+++ b/chrome/android/java/res/layout/account_chooser_dialog_item.xml
@@ -3,7 +3,7 @@
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file. -->
 
-<LinearLayout
+<RelativeLayout

[gone, 2016/12/08 01:32:44]

Why do you switch to a RelativeLayout from a LinearLayout?  You're not putting
anything underneath anything else, AFAICT, so everything fits fine with a
horizontal layout.

[jdoerrie, 2016/12/13 17:24:48]

I initially had difficulties getting a right aligned info button working. In the
latest patch set I introduced a Space View for this purpose. Please let me know
if this is more appropriate.

     xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
@@ -15,14 +15,16 @@
         android:id="@+id/profile_image"
         android:layout_width="40dp"
         android:layout_height="40dp"
-        android:layout_gravity="center_vertical"
+        android:layout_centerVertical="true"

[gone, 2016/12/08 01:32:44]

What happens if you just set android:gravity=center_vertical for the
RelativeLayout instead of setting it on each of the children individually?

[jdoerrie, 2016/12/13 17:24:48]

This would not work unfortunately, android:gravity is not defined for
RelativeLayout. The doc says android:layout_centerVertical centers the child
within it's parent, which is why we would need to repeat it for all elements:
https://developer.android.com/reference/android/widget/RelativeLayout.LayoutP...

This might be a moot point, since I reverted back to a LinearLayout in the
latest patchset.

[gone, 2016/12/13 23:14:29]

Now that you've switched to using the linear layout, does my original comment
about setting this on the parent apply?

[jdoerrie, 2016/12/14 16:04:01]

Unfortunately it does not apply, it still needs to specified on every child
element.

[gone, 2016/12/14 18:20:42]

We're talking about android:gravity, right?  That's the one that tells the
parent layout that its children should be placed however it wants?

https://developer.android.com/reference/android/widget/LinearLayout.html#attr...

We use it in download_item_view.xml, bookmark_widget_item.xml, and a bunch of
other places, so I'm not sure why your case wouldn't work.

[jdoerrie, 2016/12/15 13:27:18]

My bad, I was looking into android:layout_gravity. android:gravity works fine.

         android:contentDescription="@null"/>
     <LinearLayout
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_gravity="center_vertical"
+        android:layout_centerVertical="true"
         android:layout_margin="8dp"
         android:layout_marginStart="16dp"
+        android:layout_toEndOf="@+id/profile_image"
+        android:layout_toStartOf="@+id/psl_info_icon"
         android:orientation="vertical">
         <TextView
             android:id="@+id/main_name"
@@ -43,4 +45,12 @@
             android:textColor="@color/descriptive_text_color"
             android:textSize="@dimen/account_chooser_dialog_title_descriptive_text_size"/>
     </LinearLayout>
-</LinearLayout>
+    <ImageView

[gone, 2016/12/08 01:32:44]

You want an ImageButton, not an ImageView.  See how we set the background for
other ImageButtons so that you keep the Material rippling effect.

[jdoerrie, 2016/12/13 17:24:48]

Done.

+        android:contentDescription="@null"

[gone, 2016/12/08 01:32:44]

nit: IDs first, then android:layout_* things, then everything else.  Makes it
easier to find individual views and understand how they're placed relative to
the parent.

[jdoerrie, 2016/12/13 17:24:48]

Done.

+        android:id="@+id/psl_info_icon"
+        android:layout_alignParentEnd="true"
+        android:layout_centerVertical="true"
+        android:layout_height="@dimen/psl_info_icon_height"
+        android:layout_width="@dimen/psl_info_icon_width"
+        android:padding="@dimen/psl_info_icon_padding"/>
+</RelativeLayout>