Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4910)

Unified Diff: chrome/browser/password_manager/credential_android.cc

Issue 2541693004: Add Information Tooltip for Public Suffix List Matches (Closed)
Patch Set: Addressed Nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/credential_android.cc
diff --git a/chrome/browser/password_manager/credential_android.cc b/chrome/browser/password_manager/credential_android.cc
index 4f2f5a50902918731dbe2e1582bffc5638c7395a..31d730f8967f27bf887875c01d69e144d58d84c5 100644
--- a/chrome/browser/password_manager/credential_android.cc
+++ b/chrome/browser/password_manager/credential_android.cc
@@ -17,6 +17,10 @@ base::android::ScopedJavaLocalRef<jobject> CreateNativeCredential(
int position) {
using base::android::ConvertUTF16ToJavaString;
using base::android::ConvertUTF8ToJavaString;
+ std::string origin_url =
+ password_form.is_public_suffix_match
+ ? password_form.origin.GetOrigin().spec()
+ : std::string();
std::string federation =
password_form.federation_origin.unique()
? std::string()
@@ -26,6 +30,7 @@ base::android::ScopedJavaLocalRef<jobject> CreateNativeCredential(
return Java_Credential_createCredential(
env, ConvertUTF16ToJavaString(env, password_form.username_value),
ConvertUTF16ToJavaString(env, password_form.display_name),
+ ConvertUTF8ToJavaString(env, origin_url),
ConvertUTF8ToJavaString(env, federation), position);
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698