Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java

Issue 2541693004: Add Information Tooltip for Public Suffix List Matches (Closed)
Patch Set: Addressed Nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java b/chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java
index 3bbe0f909cdbb77b0bbb9f6024b7d801b845d9f3..750bf7be6921d1da3af6ec72e7ba25d5d5175da1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java
@@ -15,6 +15,7 @@ import org.chromium.base.annotations.CalledByNative;
public class Credential {
private final String mUsername;
private final String mDisplayName;
+ private final String mOriginUrl;
private final String mFederation;
private final int mIndex;
private Bitmap mAvatar;
@@ -24,12 +25,15 @@ public class Credential {
* The value is PasswordForm::username_value.
* @param displayName user friendly name to show in the UI. It can be empty.
* The value is PasswordForm::display_name.
+ * @param originUrl The origin URL for this credential, only set for PSL matches.
* @param federation Identity provider name for this credential (empty for local credentials).
* @param index position in array of credentials.
*/
- public Credential(String username, String displayName, String federation, int index) {
+ public Credential(String username, String displayName, String originUrl, String federation,
+ int index) {
mUsername = username;
mDisplayName = displayName;
+ mOriginUrl = originUrl;
mFederation = federation;
mIndex = index;
mAvatar = null;
@@ -43,6 +47,10 @@ public class Credential {
return mDisplayName;
}
+ public String getOriginUrl() {
+ return mOriginUrl;
+ }
+
public String getFederation() {
return mFederation;
}
@@ -61,8 +69,8 @@ public class Credential {
@CalledByNative
private static Credential createCredential(
- String username, String displayName, String federation, int index) {
- return new Credential(username, displayName, federation, index);
+ String username, String displayName, String originUrl, String federation, int index) {
+ return new Credential(username, displayName, originUrl, federation, index);
}
@CalledByNative

Powered by Google App Engine
This is Rietveld 408576698