Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2541663003: Remove [ConstructorCallWith=ScriptState] from Payments (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, haraken, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove [ConstructorCallWith=ScriptState] from Payments We want to deprecate [ConstructorCallWith=ScriptState] since it has lead to a programming error that leaks JS objects between worlds (see the bug). This CL replaces [ConstructorCallWith=ScriptState] with [ConstructorCallWith=Document]. BUG=669812 Committed: https://crrev.com/0db356f8c794ed884c3e13949973e148a0d54afb Cr-Commit-Position: refs/heads/master@{#435869}

Patch Set 1 #

Patch Set 2 : temp #

Patch Set 3 : temp #

Patch Set 4 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -140 lines) Patch
M third_party/WebKit/Source/modules/payments/AbortTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/ActivePaymentTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/CompleteTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp View 24 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAppManager.h View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAppManager.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 2 3 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp View 33 chunks +70 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
haraken
PTAL
4 years ago (2016-11-30 11:36:54 UTC) #2
Yuki
lgtm
4 years ago (2016-11-30 11:56:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541663003/20001
4 years ago (2016-11-30 11:56:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/346992)
4 years ago (2016-11-30 13:00:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541663003/40001
4 years ago (2016-12-02 04:26:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/316298)
4 years ago (2016-12-02 04:29:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541663003/60001
4 years ago (2016-12-02 04:33:53 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-02 06:40:07 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-02 06:42:50 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0db356f8c794ed884c3e13949973e148a0d54afb
Cr-Commit-Position: refs/heads/master@{#435869}

Powered by Google App Engine
This is Rietveld 408576698