third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp - Issue 2541663003: Remove [ConstructorCallWith=ScriptState] from Payments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

Issue 2541663003: Remove [ConstructorCallWith=ScriptState] from Payments (Closed)

Patch Set: temp Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequest.idl ('k') | third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

index 374e6b776ddedc167ac648020b27dea2be649a30..dc0b5694e88ffe229d4603f71f7ee4c7b5d3db23 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

@@ -132,9 +132,9 @@ TEST_P(PaymentRequestDetailsTest, ValidatesDetails) {

SecurityOrigin::create(KURL(KURL(), "https://www.example.com/")));

PaymentOptions options;

options.setRequestShipping(true);

- PaymentRequest::create(

- scope.getScriptState(), buildPaymentMethodDataForTest(),

- GetParam().buildDetails(), options, scope.getExceptionState());

+ PaymentRequest::create(scope.document(), buildPaymentMethodDataForTest(),

+ GetParam().buildDetails(), options,

+ scope.getExceptionState());

EXPECT_EQ(GetParam().expectException(),

scope.getExceptionState().hadException());