Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2541533004: Remove runtime 'dart_app' as it became identical to 'vm'. (Closed)

Created:
4 years ago by rmacnak
Modified:
4 years ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove runtime 'dart_app' as it became identical to 'vm'. Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing. Update status files to reflect these changes. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/1ebeb799429a75974d3a76ccf8d40e28996b0648

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -128 lines) Patch
M pkg/pkg.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/service.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M samples/samples.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/benchmark_smoke/benchmark_smoke.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-co19.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 2 7 chunks +11 lines, -11 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M tests/html/html.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M tests/language/language.status View 1 2 9 chunks +15 lines, -15 lines 0 comments Download
M tests/lib/lib.status View 1 2 4 chunks +8 lines, -11 lines 0 comments Download
M tests/standalone/standalone.status View 8 chunks +15 lines, -12 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 2 5 chunks +16 lines, -13 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 2 chunks +3 lines, -32 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 2 5 chunks +15 lines, -12 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years ago (2016-12-01 22:26:41 UTC) #2
siva
lgtm
4 years ago (2016-12-02 00:37:55 UTC) #3
rmacnak
4 years ago (2016-12-02 00:47:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1ebeb799429a75974d3a76ccf8d40e28996b0648 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698