Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: tools/testing/dart/runtime_configuration.dart

Issue 2541533004: Remove runtime 'dart_app' as it became identical to 'vm'. (Closed)
Patch Set: sync Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index 97c918a9303d83e148f5e7d38a538746748f0518..5008c2d98e3f8a40d3c3a8a6ffb3675e941c2d62 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -218,7 +218,9 @@ class StandaloneDartRuntimeConfiguration extends DartVmRuntimeConfiguration {
Map<String, String> environmentOverrides) {
String script = artifact.filename;
String type = artifact.mimeType;
- if (script != null && type != 'application/dart') {
+ if (script != null &&
+ type != 'application/dart' &&
+ type != 'application/dart-snapshot') {
throw "Dart VM cannot run files of type '$type'.";
}
String executable = suite.configuration['noopt']
@@ -230,37 +232,6 @@ class StandaloneDartRuntimeConfiguration extends DartVmRuntimeConfiguration {
}
}
-class DartAppRuntimeConfiguration extends DartVmRuntimeConfiguration {
- final bool useBlobs;
- DartAppRuntimeConfiguration({bool useBlobs}) : useBlobs = useBlobs;
-
- List<Command> computeRuntimeCommands(
- TestSuite suite,
- CommandBuilder commandBuilder,
- CommandArtifact artifact,
- List<String> arguments,
- Map<String, String> environmentOverrides) {
- String script = artifact.filename;
- String type = artifact.mimeType;
- if (script != null && type != 'application/dart-snapshot') {
- throw "dart_app cannot run files of type '$type'.";
- }
-
- var args = new List();
- args.addAll(arguments);
- for (var i = 0; i < args.length; i++) {
- if (args[i].endsWith(".dart")) {
- args[i] = "${artifact.filename}/out.jitsnapshot";
- }
- }
-
- return <Command>[
- commandBuilder.getVmCommand(suite.dartVmBinaryFileName,
- args, environmentOverrides)
- ];
- }
-}
-
class DartPrecompiledRuntimeConfiguration extends DartVmRuntimeConfiguration {
final bool useBlobs;
DartPrecompiledRuntimeConfiguration({bool useBlobs}) : useBlobs = useBlobs;
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698