Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2541513005: [Chromecast] Start CastShellActivity successful on cast for Android (Closed)

Created:
4 years ago by yucliu1
Modified:
4 years ago
Reviewers:
slan, Simeon, alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Start CastShellActivity successful on cast for Android 1. DumpsateWriter.writeDumpValues prints a warning message if it's not created. 2. Move libcast_shell_android to shared_library in GN. 3. Other GN deps fix. BUG=None TEST=Build cast for Android and display web page Committed: https://crrev.com/5c1cc4872a1883e010bdb86aa986bb0580b8faa2 Cr-Commit-Position: refs/heads/master@{#435700}

Patch Set 1 #

Patch Set 2 : Remove unnecessary dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chromecast/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M chromecast/base/java/src/org/chromium/chromecast/base/DumpstateWriter.java View 3 chunks +6 lines, -3 lines 0 comments Download
M chromecast/browser/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
yucliu1
Patch for public cast for Android.
4 years ago (2016-12-01 00:27:16 UTC) #3
alokp
lg2m, but should be reviewed by sanfin@
4 years ago (2016-12-01 05:19:07 UTC) #4
slan
lgtm, sanfin must sign off
4 years ago (2016-12-01 17:07:31 UTC) #5
Simeon
On 2016/12/01 00:27:16, yucliu1 wrote: > Patch for public cast for Android. lgtm.
4 years ago (2016-12-01 17:47:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541513005/20001
4 years ago (2016-12-01 19:17:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 20:35:40 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-01 20:38:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c1cc4872a1883e010bdb86aa986bb0580b8faa2
Cr-Commit-Position: refs/heads/master@{#435700}

Powered by Google App Engine
This is Rietveld 408576698