Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: chromecast/base/java/src/org/chromium/chromecast/base/DumpstateWriter.java

Issue 2541513005: [Chromecast] Start CastShellActivity successful on cast for Android (Closed)
Patch Set: Remove unnecessary dep Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/BUILD.gn ('k') | chromecast/browser/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/base/java/src/org/chromium/chromecast/base/DumpstateWriter.java
diff --git a/chromecast/base/java/src/org/chromium/chromecast/base/DumpstateWriter.java b/chromecast/base/java/src/org/chromium/chromecast/base/DumpstateWriter.java
index f9edaee4e48329859aeb254895bbc40422eacdbf..3c417d6f286c1520d118fa82871aab18ec16be05 100644
--- a/chromecast/base/java/src/org/chromium/chromecast/base/DumpstateWriter.java
+++ b/chromecast/base/java/src/org/chromium/chromecast/base/DumpstateWriter.java
@@ -4,6 +4,7 @@
package org.chromium.chromecast.base;
+import org.chromium.base.Log;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
@@ -16,10 +17,12 @@ import java.util.Map;
*/
@JNINamespace("chromecast")
public final class DumpstateWriter {
- private Map<String, String> mDumpValues;
+ private static final String TAG = "DumpstateWriter";
private static DumpstateWriter sDumpstateWriter;
+ private Map<String, String> mDumpValues;
+
public DumpstateWriter() {
sDumpstateWriter = this;
mDumpValues = new HashMap<>();
@@ -34,8 +37,8 @@ public final class DumpstateWriter {
@CalledByNative
private static void addDumpValue(String name, String value) {
if (sDumpstateWriter == null) {
- throw new IllegalStateException(
- "DumpstateWriter must be created before adding values.");
+ Log.w(TAG, "DumpstateWriter must be created before adding values: %s: %s", name, value);
+ return;
}
sDumpstateWriter.mDumpValues.put(name, value);
}
« no previous file with comments | « chromecast/BUILD.gn ('k') | chromecast/browser/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698