Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2541433003: [PageLoad Metrics] Add NavigationTo* FCP and FMP to H2/QUIC/H11 metrics (Closed)

Created:
4 years ago by jkarlin
Modified:
4 years ago
CC:
chromium-reviews, csharrison+watch_chromium.org, asvitkine+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PageLoad Metrics] Add NavigationTo* FCP and FMP to H2/QUIC/H11 metrics BUG=669527 Committed: https://crrev.com/201ca7e8fa5e83a3bff548ff267faf37cd62b4b2 Cr-Commit-Position: refs/heads/master@{#435475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc View 4 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
jkarlin
csharrison@ PTAL at everything rkaplow@ PTAL at histograms.xml Thanks!
4 years ago (2016-11-29 15:54:11 UTC) #4
Charlie Harrison
lgtm
4 years ago (2016-11-29 15:56:42 UTC) #5
rkaplow
lgtm
4 years ago (2016-11-30 20:42:00 UTC) #8
jkarlin
Thanks!
4 years ago (2016-11-30 22:19:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541433003/1
4 years ago (2016-11-30 22:20:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 23:33:55 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-30 23:36:42 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/201ca7e8fa5e83a3bff548ff267faf37cd62b4b2
Cr-Commit-Position: refs/heads/master@{#435475}

Powered by Google App Engine
This is Rietveld 408576698