chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc - Issue 2541433003: [PageLoad Metrics] Add NavigationTo* FCP and FMP to H2/QUIC/H11 metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc

Issue 2541433003: [PageLoad Metrics] Add NavigationTo* FCP and FMP to H2/QUIC/H11 metrics (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc

index 79ef4270941da79131472553d3249dabc8fae3d1..8b7187790482379ee84bec1dee342b0faa3bfe55 100644

--- a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc

@@ -70,9 +70,14 @@ class ProtocolPageLoadMetricsObserverTest

histogram_tester().ExpectTotalCount(

prefix + ".PaintTiming.ParseStartToFirstContentfulPaint", 1);

histogram_tester().ExpectTotalCount(

+ prefix + ".PaintTiming.NavigationToFirstContentfulPaint", 1);

+ histogram_tester().ExpectTotalCount(

prefix + ".Experimental.PaintTiming.ParseStartToFirstMeaningfulPaint",

1);

histogram_tester().ExpectTotalCount(

+ prefix + ".Experimental.PaintTiming.NavigationToFirstMeaningfulPaint",

+ 1);

+ histogram_tester().ExpectTotalCount(

prefix + ".DocumentTiming.NavigationToDOMContentLoadedEventFired", 1);

histogram_tester().ExpectTotalCount(

prefix + ".DocumentTiming.NavigationToLoadEventFired", 1);

@@ -83,7 +88,7 @@ class ProtocolPageLoadMetricsObserverTest

TEST_F(ProtocolPageLoadMetricsObserverTest, H11Navigation) {

SimulateNavigation(net::HttpResponseInfo::CONNECTION_INFO_HTTP1_1);

- CheckHistograms(5, "H11");

+ CheckHistograms(7, "H11");

}

TEST_F(ProtocolPageLoadMetricsObserverTest, H10Navigation) {

@@ -98,12 +103,12 @@ TEST_F(ProtocolPageLoadMetricsObserverTest, H09Navigation) {

TEST_F(ProtocolPageLoadMetricsObserverTest, H2Navigation) {

SimulateNavigation(net::HttpResponseInfo::CONNECTION_INFO_HTTP2);

- CheckHistograms(5, "H2");

+ CheckHistograms(7, "H2");

}

TEST_F(ProtocolPageLoadMetricsObserverTest, QuicNavigation) {

SimulateNavigation(net::HttpResponseInfo::CONNECTION_INFO_QUIC_35);

- CheckHistograms(5, "QUIC");

+ CheckHistograms(7, "QUIC");

}

TEST_F(ProtocolPageLoadMetricsObserverTest, UnknownNavigation) {