Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 2541273002: MD WebUI: Ensure the search field opens on touchscreen tap (Closed)

Created:
4 years ago by tsergeant
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Ensure the search field opens on touchscreen tap This fixes an issue where after touchscreen tapping the search icon, the browser would return focus to the search icon, immediately closing the search field. Using the native 'click' event instead of the simulated 'tap' event fixes this issue. BUG=624356 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2530293002 Cr-Commit-Position: refs/heads/master@{#434905} (cherry picked from commit 93a84398c5b2804930aa71c542617d0beae1f470) Committed: https://chromium.googlesource.com/chromium/src/+/6644a9da1415b7700bf9b8c00d85c78d4f42535d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tsergeant
4 years ago (2016-12-01 02:31:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6644a9da1415b7700bf9b8c00d85c78d4f42535d.

Powered by Google App Engine
This is Rietveld 408576698