Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2530293002: MD WebUI: Ensure the search field opens on touchscreen tap (Closed)

Created:
4 years ago by tsergeant
Modified:
4 years ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, dbeam+watch-elements_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Ensure the search field opens on touchscreen tap This fixes an issue where after touchscreen tapping the search icon, the browser would return focus to the search icon, immediately closing the search field. Using the native 'click' event instead of the simulated 'tap' event fixes this issue. BUG=624356 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/93a84398c5b2804930aa71c542617d0beae1f470 Cr-Commit-Position: refs/heads/master@{#434905}

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
tsergeant
PTAL!
4 years ago (2016-11-28 02:33:44 UTC) #5
Dan Beam
lgtm have you filed a bug or notified the Polymer team? they've been using sourceEvents ...
4 years ago (2016-11-29 04:39:09 UTC) #12
Dan Beam
On 2016/11/29 04:39:09, Dan Beam wrote: > lgtm > > have you filed a bug ...
4 years ago (2016-11-29 04:40:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530293002/20001
4 years ago (2016-11-29 05:42:58 UTC) #15
tsergeant
On 2016/11/29 04:39:09, Dan Beam wrote: > lgtm > > have you filed a bug ...
4 years ago (2016-11-29 05:44:47 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 05:47:42 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-29 05:49:19 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93a84398c5b2804930aa71c542617d0beae1f470
Cr-Commit-Position: refs/heads/master@{#434905}

Powered by Google App Engine
This is Rietveld 408576698