Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2541253002: Roll third_party/inspector_protocol to 715b83a3cfb45ce6c67b6c6fdd2c16391b5db896 (Closed)

Created:
4 years ago by kozy
Modified:
4 years ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Roll third_party/inspector_protocol to 715b83a3cfb45ce6c67b6c6fdd2c16391b5db896 This roll includes: - [inspector_protocol] always use weak pointer in DispatcherImpl::{command.name} [1] [1] https://codereview.chromium.org/2545613002/ BUG=chromium:668358 TBR=dgozman@chromium.org Committed: https://crrev.com/d6c2f4de9dfceff79bcabf26e27e36ac2af358b3 Cr-Commit-Position: refs/heads/master@{#41402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/inspector_protocol/README.v8 View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_cpp.template View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
kozy
Dmitry, please take a look.
4 years ago (2016-12-01 00:42:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2541253002/1
4 years ago (2016-12-01 01:07:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 01:35:06 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 01:35:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6c2f4de9dfceff79bcabf26e27e36ac2af358b3
Cr-Commit-Position: refs/heads/master@{#41402}

Powered by Google App Engine
This is Rietveld 408576698