Keep caret show around non-editable element under editable element

Keep caret show around non-editable element under editable element

contenteditable would lose selection near inline non-editable element
so this CL allows to return the last editable position in order not to
lose the selection.

Here is an example:
<div contenteditable>editable1 <i contenteditable=false>readonly1</i></div>
<div contenteditable>editable2 <i contenteditable=false>readonly2</i></div>
<div>readonly3</div>

When we move the selection from the end of the text node("editable "),
the selection is located in the third div and then the caret is disappeared.

BUG=669229
TEST=editing/selection/move-cursor-over-uneditable-in-contenteditable.html

[joone, 2016-12-03 01:42:05]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[joone, 2016-12-03 01:42:24]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-12-03 01:42:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 02:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 02:44:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[joone, 2016-12-07 00:28:54]

Description was changed from

==========
Return the last editable position

if editable position is not editable, return the last editable
position.

<div contenteditable>editable1 <i contenteditable=false>readonly1</i></div>
<div contenteditable>editable2 <i contenteditable=false>readonly2</i></div>
<div>readonly3</div>

BUG=669229
==========

to

==========
Keep caret show around non-editable element inside editable root

If editable position is not editable, it loses the selection.
This CL allows to return the last editable position in order not to
lose the selection.

Here is an example:
<div contenteditable>editable1 <i contenteditable=false>readonly1</i></div>
<div contenteditable>editable2 <i contenteditable=false>readonly2</i></div>
<div>readonly3</div>

BUG=669229
==========

[joone, 2016-12-07 00:34:08]

Description was changed from

==========
Keep caret show around non-editable element inside editable root

If editable position is not editable, it loses the selection.
This CL allows to return the last editable position in order not to
lose the selection.

Here is an example:
<div contenteditable>editable1 <i contenteditable=false>readonly1</i></div>
<div contenteditable>editable2 <i contenteditable=false>readonly2</i></div>
<div>readonly3</div>

BUG=669229
==========

to

==========
Keep caret show around non-editable element inside editable root

contenteditable would lose selection near inline non-editable element
so this CL allows to return the last editable position in order not to
lose the selection.

Here is an example:
<div contenteditable>editable1 <i contenteditable=false>readonly1</i></div>
<div contenteditable>editable2 <i contenteditable=false>readonly2</i></div>
<div>readonly3</div>

When we move the selection from the end of the text node("editable "), the
selection is located in the third div and then it loses the selection.

BUG=669229
==========

[joone, 2016-12-07 00:34:45]

Description was changed from

==========
Keep caret show around non-editable element inside editable root

contenteditable would lose selection near inline non-editable element
so this CL allows to return the last editable position in order not to
lose the selection.

Here is an example:
<div contenteditable>editable1 <i contenteditable=false>readonly1</i></div>
<div contenteditable>editable2 <i contenteditable=false>readonly2</i></div>
<div>readonly3</div>

When we move the selection from the end of the text node("editable "), the
selection is located in the third div and then it loses the selection.

BUG=669229
==========

to

==========
Keep caret show around non-editable element inside editable root

contenteditable would lose selection near inline non-editable element
so this CL allows to return the last editable position in order not to
lose the selection.

Here is an example:
<div contenteditable>editable1 <i contenteditable=false>readonly1</i></div>
<div contenteditable>editable2 <i contenteditable=false>readonly2</i></div>
<div>readonly3</div>

When we move the selection from the end of the text node("editable "),
the selection is located in the third div and then the caret is disappeared.

BUG=669229
==========

[joone, 2016-12-07 00:35:17]

Description was changed from

==========
Keep caret show around non-editable element inside editable root

contenteditable would lose selection near inline non-editable element
so this CL allows to return the last editable position in order not to
lose the selection.

Here is an example:
<div contenteditable>editable1 <i contenteditable=false>readonly1</i></div>
<div contenteditable>editable2 <i contenteditable=false>readonly2</i></div>
<div>readonly3</div>

When we move the selection from the end of the text node("editable "),
the selection is located in the third div and then the caret is disappeared.

BUG=669229
==========

to

==========
Keep caret show around non-editable element inside editable root

contenteditable would lose selection near inline non-editable element
so this CL allows to return the last editable position in order not to
lose the selection.

Here is an example:
<div contenteditable>editable1 <i contenteditable=false>readonly1</i></div>
<div contenteditable>editable2 <i contenteditable=false>readonly2</i></div>
<div>readonly3</div>

When we move the selection from the end of the text node("editable "),
the selection is located in the third div and then the caret is disappeared.

BUG=669229
TEST=editing/selection/move-cursor-over-uneditable-in-contenteditable.html
==========

[joone, 2016-12-07 00:36:44]

Description was changed from

==========
Keep caret show around non-editable element inside editable root

contenteditable would lose selection near inline non-editable element
so this CL allows to return the last editable position in order not to
lose the selection.

Here is an example:
<div contenteditable>editable1 <i contenteditable=false>readonly1</i></div>
<div contenteditable>editable2 <i contenteditable=false>readonly2</i></div>
<div>readonly3</div>

When we move the selection from the end of the text node("editable "),
the selection is located in the third div and then the caret is disappeared.

BUG=669229
TEST=editing/selection/move-cursor-over-uneditable-in-contenteditable.html
==========

to

==========
Keep caret show around non-editable element under editable element

contenteditable would lose selection near inline non-editable element
so this CL allows to return the last editable position in order not to
lose the selection.

Here is an example:
<div contenteditable>editable1 <i contenteditable=false>readonly1</i></div>
<div contenteditable>editable2 <i contenteditable=false>readonly2</i></div>
<div>readonly3</div>

When we move the selection from the end of the text node("editable "),
the selection is located in the third div and then the caret is disappeared.

BUG=669229
TEST=editing/selection/move-cursor-over-uneditable-in-contenteditable.html
==========

[joone, 2016-12-07 03:12:59]

joone.hur@intel.com changed reviewers:
+ yosin@chromium.org

[joone, 2016-12-07 03:13:00]

Hi yosin@ could you review this CL?
I'm trying to fix the fail in
EditingUtilitiesTest.firstEditablePositionAfterPositionInRoot

[24227:24231:1202/180131.140980:1386326930:ERROR:kill_posix.cc(84)] Unable to
terminate process group 30885: No such process
[ RUN      ] EditingUtilitiesTest.firstEditablePositionAfterPositionInRoot
../../third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp:65:
Failure
Value of: firstEditablePositionAfterPositionInRoot( PositionInFlatTree(three,
0), *host)
  Actual: P id="host" (editable)@offsetInAnchor[1]
Expected: PositionInFlatTree::afterNode(host)
Which is: P id="host" (editable)@afterAnchor
../../third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp:69:
Failure
Value of: firstEditableVisiblePositionAfterPositionInRoot(
PositionInFlatTree(three, 0), *host) .deepEquivalent()
  Actual: #text "22"@offsetInAnchor[2]
Expected: PositionInFlatTree::lastPositionInNode(host)
Which is: P id="host" (editable)@afterChildren
[  FAILED  ] EditingUtilitiesTest.firstEditablePositionAfterPositionInRoot (16
ms)
[4745/4745] EditingUtilitiesTest.firstEditablePositionAfterPositionInRoot (16
ms)

Do you have any idea?

[yosin_UTC9, 2016-12-07 05:07:15]

https://codereview.chromium.org/2541153004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2541153004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:624: if
(!isEditablePosition(editablePosition))
I think we should revise implementation of this function.

This function should be:

for (Position runner = position; runner is in highestRoot; runner =
nextPosition(runner)) {
  if (runner is editable)
    return runner;
}
return none; // there is no editable position after |position|.


Visible position canonicalization is due by caller rather than this function.