Keep caret show around non-editable element under editable element

third_party/WebKit/Source/core/editing/EditingUtilities.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 600 matching lines @@
       editablePosition.anchorNode() != &highestRoot &&
       !editablePosition.anchorNode()->isDescendantOf(&highestRoot))
     return PositionTemplate<Strategy>();
 
   // If |editablePosition| has the non-editable child skipped, get the next
   // sibling position. If not, we can't get the next paragraph in
   // InsertListCommand::doApply's while loop. See http://crbug.com/571420
   if (nonEditableNode &&
       nonEditableNode->isDescendantOf(editablePosition.anchorNode()))
     editablePosition = nextVisuallyDistinctCandidate(editablePosition);
+
+  // if |editablePosition| is not editable, return the last editable position.
+  // See http://crbug.com/669229.
+  if (!isEditablePosition(editablePosition))

[yosin_UTC9, 2016/12/07 05:07:15]

I think we should revise implementation of this function.

This function should be:

for (Position runner = position; runner is in highestRoot; runner =
nextPosition(runner)) {
  if (runner is editable)
    return runner;
}
return none; // there is no editable position after |position|.


Visible position canonicalization is due by caller rather than this function.

+    return PositionTemplate<Strategy>(&highestRoot, 1);
+
   return editablePosition;
 }
 
 Position firstEditablePositionAfterPositionInRoot(const Position& position,
                                                   Node& highestRoot) {
   return firstEditablePositionAfterPositionInRootAlgorithm<EditingStrategy>(
       position, highestRoot);
 }
 
 PositionInFlatTree firstEditablePositionAfterPositionInRoot(
@@ skipping 1511 matching lines @@
         return InputType::DeleteWordBackward;
       if (granularity == LineBoundary)
         return InputType::DeleteLineBackward;
       return InputType::DeleteContentBackward;
     default:
       return InputType::None;
   }
 }
 
 }  // namespace blink