Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2541153002: Extract 'computeMissingOverrides' in ErrorVerifier. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract 'computeMissingOverrides' in ErrorVerifier. So, we can reuse it in Quick Fixes. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c3e2c45cb348b2c984f461387fa60bc7cd8cacad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -199 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 5 chunks +17 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/error/error.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 5 chunks +188 lines, -176 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-11-30 21:54:32 UTC) #1
Brian Wilkerson
lgtm
4 years ago (2016-11-30 22:01:00 UTC) #2
scheglov
4 years ago (2016-11-30 22:04:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c3e2c45cb348b2c984f461387fa60bc7cd8cacad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698