Extract 'computeMissingOverrides' in ErrorVerifier.

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis_server.src.services.correction.fix_internal;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:core';
 
@@ skipping 17 matching lines @@
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/dart/ast/token.dart';
 import 'package:analyzer/src/dart/ast/utilities.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/dart/element/member.dart';
 import 'package:analyzer/src/dart/element/type.dart';
+import 'package:analyzer/src/dart/resolver/inheritance_manager.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:analyzer/src/generated/engine.dart';
+import 'package:analyzer/src/generated/error_verifier.dart';
 import 'package:analyzer/src/generated/java_core.dart';
 import 'package:analyzer/src/generated/parser.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/utilities_dart.dart';
 import 'package:analyzer/src/task/dart.dart';
 import 'package:path/path.dart';
 
 /**
  * A predicate is a one-argument function that returns a boolean value.
@@ skipping 230 matching lines @@
         errorCode ==
             StaticWarningCode
                 .NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_FOUR ||
         errorCode ==
             StaticWarningCode
                 .NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_FIVE_PLUS) {
       // make class abstract
       _addFix_makeEnclosingClassAbstract();
       _addFix_createNoSuchMethod();
       // implement methods
-      // TODO(scheglov) Fix another way to get unimplemented methods.
-      // AnalysisErrorWithProperties does not work with the new analysis driver.
-      if (error is AnalysisErrorWithProperties) {
-        AnalysisErrorWithProperties errorWithProperties =
-            error as AnalysisErrorWithProperties;
-        List<ExecutableElement> missingOverrides = errorWithProperties
-            .getProperty(ErrorProperty.UNIMPLEMENTED_METHODS);
-        _addFix_createMissingOverrides(missingOverrides);
-      }
+      _addFix_createMissingOverrides();
     }
     if (errorCode == StaticWarningCode.CAST_TO_NON_TYPE ||
         errorCode == StaticWarningCode.TYPE_TEST_WITH_UNDEFINED_NAME ||
         errorCode == StaticWarningCode.UNDEFINED_CLASS) {
       _addFix_importLibrary_withType();
       _addFix_createClass();
       _addFix_undefinedClass_useSimilar();
     }
     if (errorCode == StaticWarningCode.FINAL_NOT_INITIALIZED) {
       _addFix_createConstructor_forUninitializedFinalFields();
@@ skipping 963 matching lines @@
       sb.append(prefix);
     }
     // insert source
     _insertBuilder(sb, unitElement);
     // add linked positions
     _addLinkedPosition('NAME', sb, rf.rangeNode(node));
     // add proposal
     _addFix(DartFixKind.CREATE_LOCAL_VARIABLE, [name]);
   }
 
-  void _addFix_createMissingOverrides(List<ExecutableElement> elements) {
-    elements = elements.toList();
-    int numElements = elements.length;
+  void _addFix_createMissingOverrides() {
+    // prepare target
+    ClassDeclaration targetClass = node.parent as ClassDeclaration;
+    ClassElement targetClassElement = targetClass.element;
+    utils.targetClassElement = targetClassElement;
+    List<ExecutableElement> elements = ErrorVerifier
+        .computeMissingOverrides(
+            context.analysisOptions.strongMode,
+            context.typeProvider,
+            context.typeSystem,
+            new InheritanceManager(unitLibraryElement),
+            targetClassElement)
+        .toList();
     // sort by name, getters before setters
     elements.sort((Element a, Element b) {
       int names = compareStrings(a.displayName, b.displayName);
       if (names != 0) {
         return names;
       }
       if (a.kind == ElementKind.GETTER) {
         return -1;
       }
       return 1;
     });
-    // prepare target
-    ClassDeclaration targetClass = node.parent as ClassDeclaration;
-    utils.targetClassElement = targetClass.element;
     // prepare SourceBuilder
     int insertOffset = targetClass.end - 1;
     SourceBuilder sb = new SourceBuilder(file, insertOffset);
     // EOL management
     bool isFirst = true;
     void addEolIfNotFirst() {
       if (!isFirst || utils.isClassWithEmptyBody(targetClass)) {
         sb.append(eol);
       }
       isFirst = false;
     }
 
     // merge getter/setter pairs into fields
     String prefix = utils.getIndent(1);
+    int numElements = elements.length;
     for (int i = 0; i < elements.length; i++) {
       ExecutableElement element = elements[i];
       if (element.kind == ElementKind.GETTER && i + 1 < elements.length) {
         ExecutableElement nextElement = elements[i + 1];
         if (nextElement.kind == ElementKind.SETTER) {
           // remove this and the next elements, adjust iterator
           elements.removeAt(i + 1);
           elements.removeAt(i);
           i--;
           numElements--;
@@ skipping 1616 matching lines @@
       }
     }
   }
 
   void _updateList(Iterable<Element> elements) {
     for (Element element in elements) {
       _update(element);
     }
   }
 }