Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: build/android/pylib/local/device/local_device_gtest_run.py

Issue 2541093004: [Android] Try harder to run every gtest within each try. (Closed)
Patch Set: Tweak NOTRUN handling. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/local/device/local_device_gtest_run.py
diff --git a/build/android/pylib/local/device/local_device_gtest_run.py b/build/android/pylib/local/device/local_device_gtest_run.py
index e2c6a882e2fd1016b7d35cd3df0f3e1038ab5f72..ff516db43b25ffc02b2cdeec9ed6bb54c7a6a68e 100644
--- a/build/android/pylib/local/device/local_device_gtest_run.py
+++ b/build/android/pylib/local/device/local_device_gtest_run.py
@@ -422,7 +422,9 @@ class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun):
include_stack_symbols=False,
wipe_tombstones=True))
result.SetTombstones(resolved_tombstones)
- return results
+
+ not_run_tests = set(test).difference(set(r.GetName() for r in results))
mikecase (-- gone --) 2016/12/01 20:42:08 Could you explain this a bit. I thought you would
jbudorick 2016/12/02 01:45:21 At this point, results contains only what we were
+ return results, not_run_tests
#override
def TearDown(self):

Powered by Google App Engine
This is Rietveld 408576698